Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't add new footnotes #11728

Closed
kristinashu opened this issue Jan 17, 2024 · 5 comments
Closed

Can't add new footnotes #11728

kristinashu opened this issue Jan 17, 2024 · 5 comments

Comments

@kristinashu
Copy link

kristinashu commented Jan 17, 2024

Describe the bug

I'm testing out a new report at https://foundation.mofostaging.net/en/research/library/irl-online-life-is-real-life-season-7/in-transparency-we-trust-evaluating-the-effectiveness-of-watermarking-and-labeling-of-ai-generated-content/ but am unable to add a new footnote.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://foundation.mofostaging.net/cms/pages/26948/edit/
  2. Scroll down to Footnotes section at the bottom
  3. See Footnotes
image
  1. Go to Content text and try to add the Footnote
  2. See error
image

Expected behavior

Should see list of footnotes to choose from

cc @nancyt1

@jhonatan-lopes
Copy link
Contributor

I think this one should be because the wagtail-footnotes package that we're using is a fork of the wagtail-footnotes maintained by Torchbox, which was created on Mozilla to handle localisation. This resulted in the package not being updated for quite a while, and could be the reason why it's broken.

As part of the Django upgrade, I've ported the localisation changes upstream in order to eventually remove the fork. In the meantime, I've also synced up the fork to include the changes the were made upstream during the time that the fork was stale.

@jhonatan-lopes
Copy link
Contributor

From the Review App on the Django upgrade PR (#11726), it can be confirmed that the problem is the package being stale. Footnotes can be added when the package was updated. The fix should be on main soon.

@jhonatan-lopes
Copy link
Contributor

Upstream PR: torchbox/wagtail-footnotes#64

@jhonatan-lopes
Copy link
Contributor

Fork update PR: MozillaFoundation/wagtail-footnotes#3

@kristinashu
Copy link
Author

I believe this has been fixed! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants