Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS AST - Command argument range validation #630

Closed
camargo opened this issue May 8, 2023 · 0 comments · Fixed by #691
Closed

TS AST - Command argument range validation #630

camargo opened this issue May 8, 2023 · 0 comments · Fixed by #691
Assignees
Labels
feature New feature or request sequencing Anything related to the sequencing domain

Comments

@camargo
Copy link
Member

camargo commented May 8, 2023

Requires #625 to be merged.
Also requires NASA-AMMOS/aerie#927 so the parsed dictionary JSON is available in the database. After which, we can include the aerie-ampcs library as a dependency and import types to type the JSON.

Now that we have custom workers in the UI (nice work @Cobular), we need to validate numeric command arguments ranges for the sequencing EDSL and command expansion EDSL. For example as the user types a numeric sequence argument with a range defined in the command dictionary (e.g. 1-10), we should use the TypeScript AST in the custom worker to validate the range and add diagnostics (via markers) if the number is out of range.

@camargo camargo added the sequencing Anything related to the sequencing domain label May 8, 2023
@mattdailis mattdailis changed the title Commant argument range validation Command argument range validation May 9, 2023
@camargo camargo added the feature New feature or request label May 9, 2023
@camargo camargo assigned goetzrrGit and unassigned Cobular Jun 13, 2023
@goetzrrGit goetzrrGit changed the title Command argument range validation TS AST - Command argument range validation Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request sequencing Anything related to the sequencing domain
Projects
Archived in project
3 participants