Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long equations going over margins #607

Closed
4 tasks
Tracked by #623
bwbaker1 opened this issue Jan 5, 2023 · 6 comments
Closed
4 tasks
Tracked by #623

Long equations going over margins #607

bwbaker1 opened this issue Jan 5, 2023 · 6 comments
Assignees
Labels
bug Something isn't working development A task for the DS development team on APT PDF Issues in or related to PDF exporting

Comments

@bwbaker1
Copy link
Collaborator

bwbaker1 commented Jan 5, 2023

@wrynearson @naomatheus

Description:

Long equations run over the page margins. We need to determine if there is a way to create a line break (only in latex equations) or update user guide to stress that equations need to be as short as possible.

Tasks:

  • Determine if there is a way to add a "new line" character in the equation editors.
  • Update the user guide to explain how to add new lines to equations. If there is no work around, update the user guide (perhaps add a message within the tool itself) stating that equations must be as short as possible to avoid overrunning equations.
  • Update the equation LaTeX Cheatsheet icon to have text when hovered over (see image below). Currently, there is no text.

Acceptance Criteria:

  • User guide and tool are updated to reflect how to handle long equations.

Icon within equation editor should have text when hovered over.

Image

@bwbaker1 bwbaker1 added the development A task for the DS development team on APT label Jan 5, 2023
@bwbaker1 bwbaker1 added this to the PI23.2 APT Milestones milestone Jan 9, 2023
@deborahUAH deborahUAH added the bug Something isn't working label Jan 11, 2023
@wrynearson
Copy link
Member

@bwbaker1 is this a problem only in the PDF generation or also in the frontend?

@bwbaker1
Copy link
Collaborator Author

@wrynearson This occurs in both the PDF and frontend.

@wrynearson wrynearson added the PDF Issues in or related to PDF exporting label Jan 17, 2023
@wrynearson
Copy link
Member

wrynearson commented Feb 24, 2023

Currently, in the equation editor, we have a warning that tells users that their equation may be too long to be rendered properly in the PDF (or the view mode).

image

However, the user isn't prevented from inserting such a long equation, which results in view mode overflow and PDF clipping.

image

image

According to Stack Exchange, there are several methods to insert line breaks, but this could be tricky to do automatically. This ticket should be in a later sprint – I moved it to S4.

We should assess whether a technical solution or a user guidance solution is better.

@wrynearson
Copy link
Member

@bwbaker1 this is ready for your review

@bwbaker1
Copy link
Collaborator Author

@wrynearson This looks good. I think we can call this done.

cc @deborahUAH

@wrynearson
Copy link
Member

This is solved for the Document PDF. This will be implemented on the Journal PDF. This is not implemented on the View mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working development A task for the DS development team on APT PDF Issues in or related to PDF exporting
Projects
None yet
Development

No branches or pull requests

5 participants