Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check version description text block #612

Closed
2 of 4 tasks
Tracked by #623
bwbaker1 opened this issue Jan 9, 2023 · 5 comments
Closed
2 of 4 tasks
Tracked by #623

Check version description text block #612

bwbaker1 opened this issue Jan 9, 2023 · 5 comments
Assignees
Labels
PDF Issues in or related to PDF exporting

Comments

@bwbaker1
Copy link
Collaborator

bwbaker1 commented Jan 9, 2023

@deborahUAH @naomatheus

Description:

An unknown section, "1 Description", appears in both PDF downloads. This section has the "Content Unavailable" placeholder text(see image below), and there does not seem to be anyway to add/edit this content. @wrynearson suggested checking to see if this is actually the ATBD version description text block.

Tasks:

  • Determine what is causing the "1 Description" section in both PDF downloads. Check to see if it is related to the ATBD version description text block.
  • Discuss with team once the cause of this section is determined.

Acceptance Criteria:

  • The cause of the "1 Description" section is discussed with team and a decision is made for how to resolve this section.
  • Resolution is implemented and works correctly when tested

###Example showing "1 Description" in PDF

Image

@bwbaker1
Copy link
Collaborator Author

@wrynearson @naomatheus @deborahUAH

This is related to the version description. So we probably need some solution if a user does not add any content into this field. See below.

editing mode:

Image

viewing mode:

Image

PDF:

Image

@deborahUAH
Copy link
Collaborator

  1. The section needs to be called Version description in the PDFs
  2. is it possible that if V1, the section is omitted from the PDFs but if any other version it is included and required?

@wrynearson
Copy link
Member

Thanks for confirming our idea @bwbaker1. We can rename the section. I will check with the team to see if version-driven PDF structure modifications are possible, but I would image that is tricky. cc: @batpad

@wrynearson wrynearson added the PDF Issues in or related to PDF exporting label Jan 17, 2023
@naomatheus
Copy link
Collaborator

naomatheus commented Jan 20, 2023

Correct, the "Description" header is the PDF title for the "Version Description" element.
They are now named the same.

Regarding leaving out "Version Description" under specific ATBD version circumstances. I can confirm this is possible in the journal type ATBD. I'll update you when I can verify this is possible with the non-journal/document type ATBD.

Reference PR

cc @wrynearson

@wrynearson
Copy link
Member

This is fixed with the new PDF generation approach: #638

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PDF Issues in or related to PDF exporting
Projects
None yet
Development

No branches or pull requests

4 participants