Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF downloads sometimes do not show in the local directory #770

Closed
1 task
Tracked by #771
bwbaker1 opened this issue Jul 11, 2023 · 7 comments
Closed
1 task
Tracked by #771

PDF downloads sometimes do not show in the local directory #770

bwbaker1 opened this issue Jul 11, 2023 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@bwbaker1
Copy link
Collaborator

bwbaker1 commented Jul 11, 2023

Description

User notified me that when downloading a PDF, he does not see it in the "downloads" directory and he cannot find it. We did some internal testing and found this.

  1. PDFs download as expected to the "downloads" directory on MacBook (checked Chrome and Safari).
  2. PDFs do not seem to download to a directory on PC (checked with Chrome). Tester did receive a toast stating that the PDF was successfully downloaded. See video.
Dashboard.Algorithm.Publication.Tool.-.Google.Chrome.2023-07-10.15-20-25.mov

Acceptance Criteria:

  • PDF downloads to the appropriate directory for all users
@bwbaker1 bwbaker1 added the bug Something isn't working label Jul 11, 2023
@bwbaker1
Copy link
Collaborator Author

@frozenhelium @sunu @thenav56 Could one of you look into this issue?

@thenav56
Copy link
Collaborator

thenav56 commented Jul 12, 2023

@bwbaker1 @frozenhelium @sunu
With a quick glance, it looks like the browser has blocked the download popup. You can see it in the top right corner of the address bar at 0:30.

2023-07-12-085020

Maybe we can add a message in the notification saying the user needs to enable the popup or provide the link to download/view.

@sunu
Copy link
Collaborator

sunu commented Jul 12, 2023

Yea, looks like Chrome is blocking the download popup.

@bwbaker1 Could you try out these instructions to allow popups on APT site and see if that fixes the issue for the user: https://support.google.com/chrome/answer/95472?hl=en&co=GENIE.Platform=Desktop. The instructions are under the "Allow pop-ups and redirects from a site" section.

@bwbaker1
Copy link
Collaborator Author

@sunu @thenav56 That solved the issue. I think it will be more user friendly if we provide the link to download/view. Thoughts?

@sunu
Copy link
Collaborator

sunu commented Jul 13, 2023

@bwbaker1 Yes, we can include the link directly in the notification as well.

@bwbaker1
Copy link
Collaborator Author

bwbaker1 commented Aug 2, 2023

@wrynearson Looks good on staging.

@wrynearson
Copy link
Member

Right now, we instruct users to allow pop-ups. It would be better if we added a download link directly in the success toast. I'll close this ticket for now, but we could add that feature in a new ticket later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants