Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No parentheses should enclose a reference if it is at the beginning of a sentence #785

Closed
1 task
Tracked by #781 ...
wrynearson opened this issue Aug 4, 2023 · 6 comments
Closed
1 task
Tracked by #781 ...
Assignees

Comments

@wrynearson
Copy link
Member

wrynearson commented Aug 4, 2023

From #781

There should not be a parenthesis when a sentence begins a reference.

Image

AC

  • No parentheses should enclose a reference if it is at the beginning of a sentence
@wrynearson
Copy link
Member Author

@kamicut, if this is difficult, could you scope out the LoE earlier in the sprint?

@bwbaker1
Copy link
Collaborator

bwbaker1 commented Aug 7, 2023

@wrynearson We identified three types of potential cases of adding reference(s).

  1. At the beginning of a sentence, which has a different format. Note there may or may not be a comma following the reference. Examples:
    According to the American Psychological Association (2000), .....
    Doe (2009) states that .....

  2. Somewhere in the middle of the sentence. Note there is no punctuation following the reference and the reference gets parenthesis. Multiple citations would get one set of parenthesis. Example:
    However, a parallel study (Berndt, 1981; Doe, 2002) resulted in ......

  3. At the end of a sentence, which is followed by a period. Example:
    This is a test sentence (Berndt, 1981; Doe, 2002; Johnson et al., 2001).

@kamicut
Copy link
Collaborator

kamicut commented Aug 7, 2023

There are multiple ways we can tackle this ticket as well as #784:

In order of difficulty (in my opinion, but I differ to @frozenhelium on frontend difficulty)

  1. Remove parentheses by default, and have them be written in manually in the editor around the citation by the user
  2. Create a fixed ruleset for citations so that formatting & merging of the citations could follow the ruleset (example, no parentheses when starting a line, two citations next to each other should merge, etc.)
  3. Create a "citation display editor" component upon inserting a reference, that will allow the editor to display how a citation will look like before it's inserted into the text box.

These have varying degrees of complexity and flexibility. (1) and (3) require some manual work on the side of the user, but are a little bit more flexible. (2) would be less flexible.

@wrynearson
Copy link
Member Author

Thanks @kamicut for the summary! I think historically (before any of the DS members current working on the project joined), the idea was to value flexibility and to give the responsibility of sorting the specific details and edge cases to the user. It's a very deep rabbit hole to try to account for all of the different use cases required by users, and citations/references seem to be a pain point for users.

@wrynearson
Copy link
Member Author

@bwbaker1 we're going to meet next week and deep-dive into the AGU citation rules to help us decide how to move forward with this, because this is more than just a question about parentheses

@bwbaker1
Copy link
Collaborator

@wrynearson I discussed the issues related to in-text citations with Aaron.

  1. We agree that the best solution is to do nothing for this use case. Hopefully, this will encourage user(s) to rephrase their sentences and place the citations at the end. Citations at the beginning of a sentence are less common anyways.

We can reassess this after the one-year maintenance period based on user feedback.

@bwbaker1 bwbaker1 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants