Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: figure/table captions do not work correctly with special characters #878

Closed
Tracked by #872
bwbaker1 opened this issue Jul 1, 2024 · 7 comments
Closed
Tracked by #872
Assignees
Labels
bug Something isn't working

Comments

@bwbaker1
Copy link
Collaborator

bwbaker1 commented Jul 1, 2024

Description

Table and figure captions do not display correctly on a PDF when the caption includes special characters. The caption is cutoff once a special character is used.

Figure example:
Edit mode

Image

View mode

Image

PDF view

Image

@bwbaker1
Copy link
Collaborator Author

bwbaker1 commented Jul 1, 2024

@wrynearson A user brought this to my attention today. It is someone that is actively working on several ATBDs.

@wrynearson wrynearson added the bug Something isn't working label Jul 2, 2024
@wrynearson
Copy link
Member

Hi @bwbaker1, I wasn't able to reproduce this. I tested with this document and added a bunch of "special characters" (like ©, ® and 😀, 🌍, 🎉, 👋 and ₂ ²) to the 2nd image caption in the "Additional Information" subsection.

They all rendered correctly in the PDF preview and exported PDF.

Did you see this issue in more than this document? Which document was it in?

@bwbaker1
Copy link
Collaborator Author

bwbaker1 commented Jul 3, 2024

@wrynearson Interesting. I created a new document and still had the issue. I did an end-to-end screen recording so you can see exactly what I am doing.

Screen.Recording.2024-07-03.at.9.54.29.AM.mov

@wrynearson
Copy link
Member

Thank you so much for the screen recording! They're super helpful for debugging issues.

I see that you used the rich text editor and that everything after the bolded text was cut out. That's different than how I tested it (adding non-ASCII characters that I copied in from elsewhere). Using your method, I'm able to reproduce the issue.

@batpad @kamicut @vgeorge – any ideas as to what's happening?

@wrynearson
Copy link
Member

@bwbaker1 this is fixed, but we're having issues deploying it to staging.

@bwbaker1
Copy link
Collaborator Author

@wrynearson Ok, just let me know when it is ready for testing.

@bwbaker1
Copy link
Collaborator Author

@wrynearson This works now. It is ready for production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants