Add inputs for missing value codes and explanations in the attribute editor #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #612
rushirajnenuji
approved these changes
Jul 31, 2023
|
This is awesome @robyngit, thank you!!! |
In new Cesium-based catalog search view Issue #2160
- Use in the EML211 model Issue #1380
Include tests for parsing and updating the DOM when there's a url function Issue #1380
- CitationModel, DataONEObject, SolrResult, and MetadataView previously all used very similar DOI methods - These methods have been moved to the appModel, the other views/models call those - Also added getCanonicalDOIIRI to DataONEObject Relates to #1380
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the EML Attribute editor, add inputs for missing value codes:
These changes include:
EMLMissingValueCodemodel and associatedEMLMissingValueCodescollectionEMLMissingValueCodeView(renders one model) and anEMLMissingValueCodesView(renders the collection)The views show an error notification if a MissingValueCode is invalid (e.g. has a code but no explanation). New blank rows are added automatically, similar to the behaviour in other inputs in the editor.
Fixes issue #612