You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[ ] Bug report
[x] Feature request
[ ] Documentation issue or request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Support request => Please do not submit support request here
Current behavior
in some components, ng-zorro use subject to emit values when event callback triggered.
But this is not a good practice when writing Angular component.
Expected behavior
Use Observable.fromEvent / Observable.create to wrap eventListener, and dispose the eventListener in teardown logic when unsubscribe in ngOnDestroy.
Minimal reproduction of the problem with instructions
@vthinkxie@trotyl what do you think about this issue. if you are approving my suggestion, I will help you to change all Subject to Observable just like Dropdown.
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.
lockbot
locked as resolved and limited conversation to collaborators
Sep 17, 2019
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I'm submitting a...
Current behavior
in some components, ng-zorro use subject to emit values when event callback triggered.
But this is not a good practice when writing Angular component.
Expected behavior
Use Observable.fromEvent / Observable.create to wrap eventListener, and dispose the eventListener in teardown logic when unsubscribe in ngOnDestroy.
Minimal reproduction of the problem with instructions
see #148
What is the motivation / use case for changing the behavior?
performance imporve
The text was updated successfully, but these errors were encountered: