Skip to content

Commit

Permalink
Merge develop, resolve tiny conflict
Browse files Browse the repository at this point in the history
  • Loading branch information
Myoldmopar committed Aug 19, 2024
2 parents be14c93 + e1599d2 commit 498a892
Show file tree
Hide file tree
Showing 11 changed files with 4,111 additions and 112 deletions.
10 changes: 5 additions & 5 deletions doc/input-output-reference/src/overview/group-daylighting.tex
Original file line number Diff line number Diff line change
Expand Up @@ -505,21 +505,21 @@ \subsubsection{Outputs}\label{outputs-1-004}

\subsection{Output:IlluminanceMap}\label{outputilluminancemap}

The Output:IlluminanceMap object expands on the reporting capabilities of the daylighting simulation. For any zone simulated with \hyperref[daylightingcontrols-000]{Daylighting:Controls}, the illuminance map can generate up to 2,500 points of additional daylighting illuminance values. The resulting map is output as a comma delimited text file that can be imported into a spreadsheet program for rapid visualization of the daylighting illuminance patterns in a zone. The values are produced on an hourly basis. The Z height of the map is constant (parallel to a flat floor). More than one illuminance map can be created for a zone. IlluminanceMap output is available only when SplitFlux daylighting method is selected in \hyperref[daylightingcontrols-000]{Daylighting:Controls} object.
The Output:IlluminanceMap object expands on the reporting capabilities of the daylighting simulation. For any space or zone simulated with \hyperref[daylightingcontrols-000]{Daylighting:Controls}, the illuminance map can generate up to 2,500 points of additional daylighting illuminance values. The resulting map is output as a comma delimited text file that can be imported into a spreadsheet program for rapid visualization of the daylighting illuminance patterns in a space or zone. The values are produced on an hourly basis. The Z height of the map is constant (parallel to a flat floor). More than one illuminance map can be created for a space or zone. IlluminanceMap output is available only when SplitFlux daylighting method is selected in \hyperref[daylightingcontrols-000]{Daylighting:Controls} object.

\subsubsection{Inputs}\label{inputs-4-006}

\paragraph{Field: Name}\label{field-name-2-007}

The name of the map object.

\paragraph{Field: Zone Name}\label{field-zone-name-2-000}
\paragraph{Field: Zone or Space Name}\label{field-zone-name-2-000}

Reference to a zone with \hyperref[daylightingcontrols-000]{Daylighting:Controls}. The zone must lie completely within a single solar enclosure.
Reference to a zone or space with \hyperref[daylightingcontrols-000]{Daylighting:Controls}. If a zone name is specified, all spaces in the zone must be within the same solar enclosure.

\paragraph{Field: Z Height}\label{field-z-height}

The height or elevation of the grid of daylighting points.
The height or elevation of the grid of daylighting points. Coordinates may be world or relative as specified in the \hyperref[globalgeometryrules]{GlobalGeometryRules} object Daylighting Reference Point CoordinateSystem field. If a space name is specifice for this map, relative coodinates are relative to the origin of the zone that contains the space (spaces do not have a separate origin).

\paragraph{Field: X Minimum Coordinate}\label{field-x-minimum-coordinate}

Expand Down Expand Up @@ -551,7 +551,7 @@ \subsubsection{Inputs}\label{inputs-4-006}

Output:IlluminanceMap,
Daylit Map, ! Map Name
Daylit Zone, ! Zone Name
Daylit Zone, ! Zone or Space Name
0, ! Z Height [m]
0.1, ! X Minimum Coordinate [m]
4.9, ! X Maximum Coordinate [m]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2772,11 +2772,11 @@ \subsubsection{Inputs}\label{inputs-25-004}

\paragraph{Field: Zone or ZoneList Name}\label{field-zone-or-zonelist-name-14}

This field is the name of the \hyperref[zone]{Zone} or \hyperref[zonelist]{ZoneList} in which the internal mass will be added. When the ZoneList option is used then this internal mass object is applied to each of zone in the list. The name of the actual internal mass object in each zone becomes <Zone Name> <InternalMass Object Name> and should be less than the standard length (100 characters) for a name field. If it is greater than this standard length, it may be difficult to specify in output reporting as it will be truncated. A warning will be shown if the generated name is greater than 100 characters. If it duplicates another such concatenated name, there will be a severe error and terminate the run.
This field is the name of the \hyperref[zone]{Zone} or \hyperref[zonelist]{ZoneList} in which the internal mass will be added. When the ZoneList option is used then this internal mass object is applied to each zone in the list. The name of the actual internal mass object in each zone becomes <Zone Name> <InternalMass Object Name> and should be less than the standard length (100 characters) for a name field. If it is greater than this standard length, it may be difficult to specify in output reporting as it will be truncated. A warning will be shown if the generated name is greater than 100 characters. If it duplicates another such concatenated name, there will be a severe error and terminate the run. This field is ignored when a Space or SpaceList Name is specified.

\paragraph{Field: Space or SpaceList Name}\label{field-space-or-spacelist-name-14}

This field is the name of the \hyperref[space]{Space} or \hyperref[spacelist]{SpaceList} in which the internal mass will be added. When the SpaceList option is used then this internal mass object is applied to each space in the list. The name of the actual internal mass object in each space becomes <Space Name> <InternalMass Object Name> and should be less than the standard length (100 characters) for a name field. If it is greater than this standard length, it may be difficult to specify in output reporting as it will be truncated. A warning will be shown if the generated name is greater than 100 characters. If it duplicates another such concatenated name, there will be a severe error and terminate the run. This field is ignored when a ZoneList Name is specified for Zone or ZoneList Name. If a Space Name is used, then the Space must be part of Zone Name. If a SpaceList Name is used, then the Zone Name is ignored (even though it is a required field), and the surface is assigned to the corresponding Zone(s) for each Space in the SpaceList.
This field is the name of the \hyperref[space]{Space} or \hyperref[spacelist]{SpaceList} in which the internal mass will be added. If this field is blank (or a ZoneList Name is specified), the internal mass will be added to the last space attached to the zone. When the SpaceList option is used then this internal mass object is applied to each space in the list. The name of the actual internal mass object in each space becomes <Space Name> <InternalMass Object Name> and should be less than the standard length (100 characters) for a name field. If it is greater than this standard length, it may be difficult to specify in output reporting as it will be truncated. A warning will be shown if the generated name is greater than 100 characters. If it duplicates another such concatenated name, there will be a severe error and terminate the run. This field is ignored when a ZoneList Name is specified for Zone or ZoneList Name. If this field is entered, then the Zone or ZoneList Name is ignored, and the surface is assigned to the corresponding Zone(s) for the Space(s).

\paragraph{Field: Surface Area}\label{field-surface-area}

Expand All @@ -2789,13 +2789,15 @@ \subsubsection{Inputs}\label{inputs-25-004}
Zn002:IntM001, !- Surface Name
INTERIOR, !- Construction Name
DORM ROOMS AND COMMON AREAS, !- Zone or ZoneList Name
408.7734; !- Total area exposed to Zone {m2}
, !- Space or SpaceList Name
408.7734; !- Surface Area {m2}

InternalMass,
Zn002:IntM002, !- Surface Name
PARTITION02, !- Construction Name
DORM ROOMS AND COMMON AREAS, !- Zone or ZoneList Name
371.6122; !- Total area exposed to Zone {m2}
, !- Space or SpaceList Name
371.6122; !- Surface Area {m2}
\end{lstlisting}

\subsection{Surface Output Variables/Reports}\label{surface-output-variablesreports}
Expand Down
11 changes: 6 additions & 5 deletions idd/Energy+.idd.in
Original file line number Diff line number Diff line change
Expand Up @@ -13371,16 +13371,16 @@ InternalMass,
\type object-list
\object-list ConstructionNames
A3 , \field Zone or ZoneList Name
\required-field
\type object-list
\object-list ZoneAndZoneListNames
\note Zone the surface is a part of.
\note used to be Interior Environment
\note Zone(s) the surface is a part of.
\note This field is ignored when a Space or SpaceList Name is specified.
A4 , \field Space or SpaceList Name
\type object-list
\object-list SpaceAndSpaceListNames
\note Space the surface is a part of (optional, see description of Space object for more details).
\note Space(s) the surface is a part of.
\note This field is ignored when a ZoneList Name is specified for Zone or ZoneList Name.
\note An internal mass surface will be added to every Space in every Zone in the ZoneList.
N1 ; \field Surface Area
\required-field
\units m2
Expand Down Expand Up @@ -23840,10 +23840,11 @@ Output:IlluminanceMap,
\memo Daylighting Reference Point CoordinateSystem field
A1 , \field Name
\required-field
A2 , \field Zone Name
A2 , \field Zone or Space Name
\required-field
\type object-list
\object-list ZoneNames
\object-list SpaceNames
N1 , \field Z height
\units m
\type real
Expand Down
1 change: 1 addition & 0 deletions src/EnergyPlus/DataDaylighting.hh
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,7 @@ namespace Dayltg {
{
// Members
std::string Name; // Map name
int spaceIndex = 0; // Index to space being mapped
int zoneIndex = 0; // Index to zone being mapped
int enclIndex = 0; // Index to enclosure for this map
Real64 Z = 0.0; // Elevation or height
Expand Down
Loading

5 comments on commit 498a892

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SpaceSizingHVACPart4 (Myoldmopar) - Win64-Windows-10-VisualStudio-16: OK (2871 of 2871 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SpaceSizingHVACPart4 (Myoldmopar) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (3360 of 3706 tests passed, 5 test warnings)

Messages:\n

  • 346 tests had: Table big diffs.
  • 1 test had: AUD diffs.
  • 1 test had: BND diffs.
  • 1 test had: EIO diffs.
  • 1 test had: ESO big diffs.
  • 1 test had: MTD diffs.
  • 1 test had: MTR big diffs.
  • 1 test had: Table string diffs.
  • 5 tests had: Table small diffs.

Failures:\n

regression Test Summary

  • Passed: 467
  • Failed: 346

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SpaceSizingHVACPart4 (Myoldmopar) - x86_64-MacOS-10.18-clang-15.0.0: Tests Failed (790 of 3665 tests passed, 0 test warnings)

Failures:\n

API Test Summary

  • Failed: 10
  • notrun: 5

ConvertInputFormat Test Summary

  • Failed: 4
  • notrun: 1

integration Test Summary

  • Passed: 2
  • Failed: 794

regression Test Summary

  • Passed: 788
  • Failed: 5

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SpaceSizingHVACPart4 (Myoldmopar) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-Debug: OK (2077 of 2077 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SpaceSizingHVACPart4 (Myoldmopar) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: OK (797 of 797 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.