Proper matrix variable lookup, smh, try adding a warning annotation t…

…o diffs
NREL · Aug 28, 2024 · 9721b95 · 9721b95
1 parent 56ca807
commit 9721b95
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/.github/workflows/build_and_test_pr.yml b/.github/workflows/build_and_test_pr.yml
@@ -198,7 +198,7 @@ jobs:
       run: cat ${{ github.workspace }}/regressions/summary.js
 
     - uses: actions/github-script@v7
-      if: always() && matrix.run_regression && steps.regressions.outcome == 'failure'
+      if: always() && matrix.run_regressions && steps.regressions.outcome == 'failure'
       with:
         script: |
           const script = require('${{ github.workspace }}/regressions/summary.js')

diff --git a/scripts/dev/gha_regressions.py b/scripts/dev/gha_regressions.py
@@ -491,6 +491,7 @@ def check_all_regressions(self, base_testfiles: Path, mod_testfiles: Path, bundl
         print(f"* Diffs by Type *:\n{json.dumps(self.diffs_by_type, indent=2, sort_keys=True)}\n")
         if any_diffs:
             self.generate_markdown_summary(bundle_root)
+            print("::warning title=Regressions::Diffs Detected")
         return any_diffs