From 9721b957731fa1446bdbb1f966ed179d0e8c2429 Mon Sep 17 00:00:00 2001 From: Edwin Lee Date: Wed, 28 Aug 2024 10:20:45 -0500 Subject: [PATCH] Proper matrix variable lookup, smh, try adding a warning annotation to diffs --- .github/workflows/build_and_test_pr.yml | 2 +- scripts/dev/gha_regressions.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build_and_test_pr.yml b/.github/workflows/build_and_test_pr.yml index f30cf7932a6..be18596a581 100644 --- a/.github/workflows/build_and_test_pr.yml +++ b/.github/workflows/build_and_test_pr.yml @@ -198,7 +198,7 @@ jobs: run: cat ${{ github.workspace }}/regressions/summary.js - uses: actions/github-script@v7 - if: always() && matrix.run_regression && steps.regressions.outcome == 'failure' + if: always() && matrix.run_regressions && steps.regressions.outcome == 'failure' with: script: | const script = require('${{ github.workspace }}/regressions/summary.js') diff --git a/scripts/dev/gha_regressions.py b/scripts/dev/gha_regressions.py index 233c86100fa..eea11f23a08 100644 --- a/scripts/dev/gha_regressions.py +++ b/scripts/dev/gha_regressions.py @@ -491,6 +491,7 @@ def check_all_regressions(self, base_testfiles: Path, mod_testfiles: Path, bundl print(f"* Diffs by Type *:\n{json.dumps(self.diffs_by_type, indent=2, sort_keys=True)}\n") if any_diffs: self.generate_markdown_summary(bundle_root) + print("::warning title=Regressions::Diffs Detected") return any_diffs