Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong comparison in an if statement in Photovoltaics.cc #8635

Closed
3 tasks
dareumnam opened this issue Mar 19, 2021 · 0 comments
Closed
3 tasks

Wrong comparison in an if statement in Photovoltaics.cc #8635

dareumnam opened this issue Mar 19, 2021 · 0 comments
Assignees
Labels
Defect Includes code to repair a defect in EnergyPlus

Comments

@dareumnam
Copy link
Collaborator

Issue overview

In Photovoltaics.cc, line 708 here,

if (PVarray(PVnum).PVModelType == iSurfaceOutsideFaceCellIntegration)

PVarray(PVnum).PVModelType has to be PVarray(PVnum).CellIntegrationMode

Details

Some additional details for this issue (if relevant):

  • Platform (Operating system, version)
  • Version of EnergyPlus (if using an intermediate build, include SHA)
  • Unmethours link or helpdesk ticket number

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Defect file added (list location of defect file here)
  • Ticket added to Pivotal for defect (development team task)
  • Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)
@dareumnam dareumnam added the Defect Includes code to repair a defect in EnergyPlus label Mar 19, 2021
@dareumnam dareumnam added this to the EnergyPlus 9.5.0 milestone Mar 19, 2021
@dareumnam dareumnam self-assigned this Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Development

No branches or pull requests

1 participant