Allow HPWH and Zonal ERVs to be modeled with AFNs #8549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… conductivity correlation.
…el along with AFN.
…it comments, moved an idf statement, added test files.
Myoldmopar
added
NewFeature
|
I had built this locally and ran most of the tests. I expect everything to be green. I will not be waiting on the full gauntlet of CI to finish before merging this and moving on. |
|
Custom check is really the one I wanted to see passing here, and it already is. A couple others have already passed as well, merging this in now. @lymereJ please open an issue to look at the error file in the newly added IDFs. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview