Cleaning up LowTemperatureRadiantSystems #8569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Myoldmopar
approved these changes
Mar 1, 2021
| extern Array1D_bool MySizeFlagHydr; | ||
| extern Array1D_bool MySizeFlagCFlo; | ||
| extern Array1D_bool MySizeFlagElec; | ||
| extern Array1D_bool CheckEquipName; |
| Real64 todayRunningMeanOutdoorDryBulbTemperature = 0.0; // Current running mean outdoor air dry-bulb temperature | ||
| Real64 yesterdayRunningMeanOutdoorDryBulbTemperature = 0.0; // Running mean outdoor air dry-bulb temperature from yesterday | ||
| Real64 todayAverageOutdoorDryBulbTemperature = 0.0; // Average outdoor dry-bulb temperature for today | ||
| Real64 yesterdayAverageOutdoorDryBulbTemperature = 0.0; // Average outdoor dry-bulb temperature for yesterday |
| @@ -214,60 +173,53 @@ namespace LowTempRadiantSystem { | |||
|
|
|||
| virtual void reportLowTemperatureRadiantSystem(EnergyPlusData &state) = 0; | |||
|
|
|||
| // Default Constructor | |||
| RadiantSystemBaseData() = default; | |||
| ~RadiantSystemBaseData() = default; | |||
| Array1D<LowTempRadiantSystem::ElecRadSysNumericFieldData> ElecRadSysNumericFields; | ||
| Array1D<LowTempRadiantSystem::HydronicRadiantSysNumericFieldData> HydronicRadiantSysNumericFields; | ||
| Array1D<LowTempRadiantSystem::ConstantFlowRadDesignData> CflowRadiantSysDesign; | ||
| Array1D<LowTempRadiantSystem::VarFlowRadDesignData> HydronicRadiantSysDesign; |
There was a problem hiding this comment.
Allll these were globals. Very nice!
| ElecRadSys.allocate(1); | ||
| HydrRadSys.allocate(1); | ||
| CFloRadSys.allocate(1); | ||
| state->dataLowTempRadSys->ElecRadSys.allocate(1); |
| @@ -592,17 +504,100 @@ namespace LowTempRadiantSystem { | |||
| LowTempRadiantSystem::SystemType const SystemType // Type of radiant system: hydronic, constant flow, or electric | |||
| ); | |||
|
|
|||
| void UpdateRadSysSourceValAvg(bool &LowTempRadSysOn); // .TRUE. if the radiant system has run this zone time step | |||
| void UpdateRadSysSourceValAvg(EnergyPlusData &state, | |||
There was a problem hiding this comment.
And I was expecting this possibility as well. Looks like just this one function needed a state argument though, so that's great!
|
CI is all super green, these changes look great, merging. Thanks @jmythms |
Thank you!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Focuses on LowTemperatureRadiantSystems.*
NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE
Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Reviewer
This will not be exhaustively relevant to every PR.