Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdoor Air Details Report - part 2 #8596

Merged
merged 24 commits into from
Mar 20, 2021
Merged

Outdoor Air Details Report - part 2 #8596

merged 24 commits into from
Mar 20, 2021

Conversation

mjwitte
Copy link
Contributor

@mjwitte mjwitte commented Mar 8, 2021 •
edited
Loading

Pull request overview

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@mjwitte mjwitte added Defect Includes code to repair a defect in EnergyPlus NewFeature Includes code to add a new feature to EnergyPlus labels Mar 8, 2021
@mjwitte mjwitte mentioned this pull request Mar 12, 2021
Closed
10 tasks
@mjwitte mjwitte added this to the EnergyPlus 9.5.0 milestone Mar 12, 2021
@mjwitte
Merge remote-tracking branch 'remotes/origin/develop' into OADetailsR…
96fb09d 
…eportPart2
@mjwitte
Merge remote-tracking branch 'remotes/origin/develop' into OADetailsR…
495b1fc 
…eportPart2
@mjwitte
OA Details - Add OALimitingFactor to OA controller
c6da291
@mjwitte
OA Details - Reorder and add limiting factor columns
ba66abd
@mjwitte
OA Details - Populate limiting factor tables
bc557ff
@mjwitte
Merge remote-tracking branch 'remotes/origin/develop' into OADetailsR…
678f582 
…eportPart2
@mjwitte
Merge remote-tracking branch 'remotes/origin/develop' into OADetailsR…
3f17cce 
…eportPart2
@mjwitte
OA Details - Code cleanup
a3f9315
@mjwitte
Merge remote-tracking branch 'remotes/origin/develop' into OADetailsR…
653ed3b 
…eportPart2
@mjwitte
Merge remote-tracking branch 'remotes/origin/hotfixHeatBalFiniteDiffF…
b6f9f88 
…orWindows' into OADetailsReportPart2
@mjwitte
Merge remote-tracking branch 'remotes/origin/develop' into OADetailsR…
2db64ea 
…eportPart2
@mjwitte
OA Details - more documentation
0d926da
@mjwitte
OA Details - fix units on limiting factor output variable
97cca90
@mjwitte
Merge remote-tracking branch 'remotes/origin/develop' into OADetailsR…
1a70fc2 
…eportPart2
@mjwitte mjwitte marked this pull request as ready for review March 18, 2021 22:10
@mjwitte mjwitte requested a review from Myoldmopar March 18, 2021 22:12
@mjwitte
Copy link
Contributor Author

mjwitte commented Mar 18, 2021

@Myoldmopar No unit tests yet, but otherwise this is ready for final review. If things are still open I can work on unit tests next week.

@Myoldmopar
Copy link
Member

CI looks good, looking over the changes now. I'm also building it locally to resolve the conflicts.

@Myoldmopar
Copy link
Member

OK conflicts resolved, and built just fine. Unit test suite passes fine, all integration tests pass fine. Regressions look identical to the last set of CI results, lots of audit, rdd, and table diffs, nothing new. Verified new values in 5ZoneAirCooled. I think this is good to go. Let me take a final peek at the code changes and this will likely merge. Thanks @mjwitte

Myoldmopar
Myoldmopar approved these changes Mar 20, 2021
View reviewed changes
doc/output-details-and-examples/src/output-files/eplustbl-lt-ext-gt.tex

\subsubsection{Average Outdoor Air for Limiting Factors During Occupancy}\label{average-outdoor-air-for-limiting-factors-during-occupancy}
This subtable is the same as Outdoor Air Controller Limiting Factors by AirLoop except that it reports average flow rates in \si{\volumeFlowRate} at each limiting factor for occupied periods only.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good doc updates.

src/EnergyPlus/MixedAir.hh
constexpr int limitFactorDCV = 6; // Demand-controlled ventilation
constexpr int limitFactorNightVent = 7; // Night ventilation
constexpr int limitFactorDemandLimit = 8; // Demand-limiting
constexpr int limitFactorEMS = 9; // EMS override
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

src/EnergyPlus/SystemReports.cc
"Air System Mechanical Ventilation Flow Rate",
OutputProcessor::Unit::m3_s,
state.dataSysRpts->SysMechVentFlow(SysIndex),
"HVAC",
"Sum",
"Average",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed this improvement in the rdd diffs, good.

src/EnergyPlus/SystemReports.hh
std::vector<Real64> SysTimeAtOALimit = {0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0}; // time [hrs] at limit [n]
std::vector<Real64> SysTimeAtOALimitOcc = {0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0}; // time [hrs] at limit [n] during occupied
std::vector<Real64> SysMechVentTotAtLimitOcc = {
0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0}; // air loop mech vent total vol OA at limit [n] {m3} during occupied
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@Myoldmopar
Copy link
Member

Everything looks great here. Merging after I push the conflict resolved branch!

@Myoldmopar Myoldmopar merged commit 4d0abd3 into develop Mar 20, 2021
@Myoldmopar Myoldmopar deleted the OADetailsReportPart2 branch March 20, 2021 15:00
@mjwitte mjwitte mentioned this pull request Mar 31, 2021
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Myoldmopar Myoldmopar Myoldmopar approved these changes

Assignees
No one assigned
Labels
Defect Includes code to repair a defect in EnergyPlus NewFeature Includes code to add a new feature to EnergyPlus
Projects
None yet
Milestone
EnergyPlus 9.5.0
Development

Successfully merging this pull request may close these issues.

Outdoor Air Details Followup
7 participants
@mjwitte @Myoldmopar @nrel-bot @nrel-bot-2 @nrel-bot-3 @nrel-bot-2b @nrel-bot-2c