Fix idf transition issues in EMS Actuator

[LipingWang]

Pull request overview

• Fixes Issues for idf transition between different EnergyPlus versions #8523
• If "AirTerminal:SingleDuct:Uncontrolled" is used as the "Actuated Component Type" in the object "EnergyManagementSystem:Actuator" of a model from an earlier EnergyPlus version, update the field "Actuated Component Type" in the object "EnergyManagementSystem:Actuator" from "AirTerminal:SingleDuct:Uncontrolled" to "AirTerminal:SingleDuect:ConstantVolume:NoReheat" during the idf transition.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[Myoldmopar]

I built this and confirmed the transition works well locally. However, the 9.2 to 9.3 transition doesn't actually convert the uncontrolled object to the noreheat one. So is this change actually appropriate?

Running the transition I get:

** Warning ** IP: IDF line~374 Obsolete object=AirTerminal:SingleDuct:Uncontrolled, encountered. Should be replaced with new object=AirTerminal:SingleDuct:ConstantVolume:NoReheat

Maybe this change should actually be in the 9.4 transition rules?

[LipingWang]

The warning message seems related to a comment line for the original air terminal object group. During the transition, the comment line was not updated.
!- =========== ALL OBJECTS IN CLASS: AIRTERMINAL:SINGLEDUCT:UNCONTROLLED ===========
This fix is to update the field "Actuated Component Type" in the object "EnergyManagementSystem:Actuator" during the idf transition.

[Myoldmopar]

Ahhh, OK, so that warning message is misleading. Based on that warning message, it seemed that the 9.2 to 9.3 transition program was not actually converting the air terminal to the new type, instead just telling the user they needed to do it. But really the transition program was actually doing the transition. Making this valid. OK, all good here, thanks @LipingWang , merging.