Global-Psychrometric

[jmythms]

Deglobalizing multiple small files.

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[Myoldmopar]

@jmythms in case you couldn't see the build results, it's failing to build with this:

"build_results": [
{
 "filename": "tst/EnergyPlus/unit/Psychrometrics.unit.cc",
 "linenumber": "225",
 "colnumber": "21",
 "messagetype": "error",
 "message": "no member named 'iPsyErrIndex' in namespace 'EnergyPlus::Psychrometrics'"
}
],

[jmythms]

@Myoldmopar Thank you, I was struggling with that.

[Myoldmopar]

@jmythms I pulled develop into the branch and resolved a few hundred conflicts. After a small bit of cleanup work, it built fine, ran unit tests serially just fine, ran integration tests fine, and amazingly, zero regressions at all! This is going right in. Thanks!!

[jmythms]

Thank you very much!!!