IPython "WARNING" log level

[mrakitin]

An alternative fix/workaround of NSLS-II/nslsii#115. I tested it, and now it does not print the [TerminalIPythonApp] messages to the screen. It would be still nice to have it configurable in nslsii.

[mrakitin]

@andrewmkiss, did it work for you?

[jklynch]

This looks like a good idea. I did like the way we saw the startup scripts running at beamlines that do not already print that to the console, so I am reluctant to apply it everywhere. On the other hand we probably don't want a high level of ipython logging.

[mrakitin]

Thanks for your review, @jklynch! What's interesting, this change only affects the messages printed to the terminal. I didn't see the log entries in the bluesky_ipython.log file are affected.

[jklynch]

I had to think about it for a while. I guess we are currently sending only ipython console input, output, and exceptions to bluesky_ipython.log. The ipython logging messages are something else.

[mrakitin]

Yep, that's what I've noticed too.

[andrewmkiss]

@andrewmkiss, did it work for you?

Sorry, we have been busy with the beamline. I can try to check this on Friday.

[jklynch]

I want to emphasize that I think at beamlines that do not explicitly print startup script names the current behavior is valuable and I would like to keep it. I have not noticed other IPython logging messages but if someone has an example I would be interested to see it.

Also since these messages are coming from the usual python logging framework it should be possible to send them to the bluesky ipython log file, which would make me happy.

[mrakitin]

Also since these messages are coming from the usual python logging framework it should be possible to send them to the bluesky ipython log file, which would make me happy.

The IPython In/Out commands/output are saved to the /var/log/bluesky/bluesky_ipython.log file.

I'll rebase on master to resolve the merge conflicts, and we will re-review.

[mrakitin]

Looking into here, it seems like the fix was already added to the master branch. Not sure how much we need from this PR then. Just new lines? 😄

[andrewmkiss]

Yes, I think I had added the one or two lines of code to "test" before merging and those lines of code were eventually absorbed into master. I can approve the changes. Do we still need to merge?

[mrakitin]

Thanks for the re-review, Andy. Let's merge to have a slightly better formatting :)