From 138387e518ecab6b1ff5d543dddf98d60556cc97 Mon Sep 17 00:00:00 2001
From: Yuhong Wen <yuhongw@nvidia.com>
Date: Tue, 13 Aug 2024 15:34:02 -0400
Subject: [PATCH] Improve the kill children processes (#2789)

* use process.kill() to kill the children processes.

* removed the sig argument.

* removed no use import.
---
 nvflare/private/fed/app/utils.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/nvflare/private/fed/app/utils.py b/nvflare/private/fed/app/utils.py
index d3b0c0ae82..b68c5e0c5e 100644
--- a/nvflare/private/fed/app/utils.py
+++ b/nvflare/private/fed/app/utils.py
@@ -13,7 +13,6 @@
 # limitations under the License.
 
 import os
-import signal
 import sys
 import threading
 import time
@@ -49,14 +48,14 @@ def check_parent_alive(parent_pid, stop_event: threading.Event):
         time.sleep(1)
 
 
-def kill_child_processes(parent_pid, sig=signal.SIGTERM):
+def kill_child_processes(parent_pid):
     try:
         parent = psutil.Process(parent_pid)
     except psutil.NoSuchProcess:
         return
     children = parent.children(recursive=True)
     for process in children:
-        process.send_signal(sig)
+        process.kill()
 
 
 def create_admin_server(fl_server: FederatedServer, server_conf=None, args=None, secure_train=False):