Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jitify compile doesn't parse numbers with separators and suffix correctly #135

Open
pmattione-nvidia opened this issue May 2, 2024 · 2 comments

Comments

@pmattione-nvidia
Copy link

Describe the bug
The jitify compile doesn't parse numbers with separators and suffix correctly. For example, "1'000ULL".

Steps/Code to reproduce bug
This can be reproduced by using a number like this in a header used by the jitify compilation, such as fixed_point.hpp in the cuDF library.

@benbarsdell
Copy link
Member

Thanks, I've pushed a fix to #131 (is that the branch you're using?)

(I had actually fixed this already but forgot to push it).

@pmattione-nvidia
Copy link
Author

Great! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants