Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Some fast parquet tests fail if the time zone is not UTC #10411

Closed
revans2 opened this issue Feb 12, 2024 · 0 comments · Fixed by #10419
Closed

[BUG] Some fast parquet tests fail if the time zone is not UTC #10411

revans2 opened this issue Feb 12, 2024 · 0 comments · Fixed by #10419
Assignees
Labels
bug Something isn't working good first issue Good for newcomers test Only impacts tests

Comments

@revans2
Copy link
Collaborator

revans2 commented Feb 12, 2024

Describe the bug

FAILED ../../src/main/python/fastparquet_compatibility_test.py::test_reading_file_written_by_spark_cpu[Timestamp(not_null)0][DATAGEN_SEED=0, INJECT_OOM] - AssertionError: GPU and CPU int values are different at [0, 'a']
FAILED ../../src/main/python/fastparquet_compatibility_test.py::test_reading_file_written_with_gpu[Timestamp(not_null)0][DATAGEN_SEED=0, INJECT_OOM] - AssertionError: GPU and CPU int values are different at [0, 'a']
SPARK_HOME=~/src/spark_3.4.2/ TEST_PARALLEL=0 DATAGEN_SEED=0 ./run_pyspark_from_build.sh -k 'test_reading_file_written_with_gpu or test_reading_file_written_by_spark_cpu'

Note that I am running on a computer with the timezone configured to 'America/Chicago' , but TZ itself is not set to anything.

$echo $TZ

If I set to TZ='UTC' or TZ='America/Chicago' then it works just fine, so I think this is a bug in how our test code detects time zones. It is probably really minor.

@revans2 revans2 added bug Something isn't working ? - Needs Triage Need team to review and classify test Only impacts tests labels Feb 12, 2024
@mattahrens mattahrens added good first issue Good for newcomers and removed ? - Needs Triage Need team to review and classify labels Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers test Only impacts tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants