Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] ScanJson and JsonToStructs should support parsing quoted decimal strings that are formatted by local (at least for en-US) #10470

Closed
revans2 opened this issue Feb 22, 2024 · 0 comments · Fixed by #10542
Closed

[BUG] ScanJson and JsonToStructs should support parsing quoted decimal strings that are formatted by local (at least for en-US) #10470

revans2 opened this issue Feb 22, 2024 · 0 comments · Fixed by #10542
Labels
bug Something isn't working

Comments

@revans2
Copy link
Collaborator

revans2 commented Feb 22, 2024

Describe the bug
Decimal values in JSON are odd. If the number is in quotes it is treated differently from when it is outside of quotes. If it is in quotes, then the locale can be taken into account when trying to parse it. So numbers like "1,000.001" are valid in quotes for decimals, but not outside of quotes.

In theory any local that java supports could also be supported for parsing these quoted string numbers. Sadly numbers from Thai and Hindi appear to be supported for en-US which is the default.

Not sure how much we want to split this up or what, but it is a bit complicated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make JSON parsing common between JsonToStructs and ScanJson revans2/spark-rapids
2 participants
@revans2 @mattahrens