Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests failures in parquet_write_test.py #11024

Open
Tracked by #11004
razajafri opened this issue Jun 8, 2024 · 4 comments
Open
Tracked by #11004

Fix tests failures in parquet_write_test.py #11024

razajafri opened this issue Jun 8, 2024 · 4 comments
Labels
bug Something isn't working Spark 4.0+ Spark 4.0+ issues

Comments

@razajafri
Copy link
Collaborator

FAILED ../../../../integration_tests/src/main/python/parquet_write_test.py::test_hive_timestamp_value
FAILED ../../../../integration_tests/src/main/python/parquet_write_test.py::test_non_empty_ctas
FAILED ../../../../integration_tests/src/main/python/parquet_write_test.py::test_parquet_write_fails_legacy_datetime
FAILED ../../../../integration_tests/src/main/python/parquet_write_test.py::test_parquet_write_roundtrip_datetime_with_legacy_rebase
FAILED ../../../../integration_tests/src/main/python/parquet_write_test.py::test_ts_write_fails_datetime_exception
@razajafri razajafri added bug Something isn't working ? - Needs Triage Need team to review and classify labels Jun 8, 2024
@razajafri razajafri added the Spark 4.0+ Spark 4.0+ issues label Jun 8, 2024
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Jun 11, 2024
@mythrocks mythrocks self-assigned this Jun 12, 2024
@mythrocks
Copy link
Collaborator

mythrocks commented Jun 12, 2024

Some of these tests fail because of the use of a deprecated conf variable:

E               pyspark.errors.exceptions.captured.AnalysisException: The SQL config 'spark.sql.legacy.parquet.datetimeRebaseModeInWrite' was removed in the version 4.0.0
. Use 'spark.sql.parquet.datetimeRebaseModeInWrite' instead.

The failing tests are:

  1. test_hive_timestamp_value
  2. test_parquet_write_roundtrip_datetime_with_legacy_rebase
  3. test_parquet_write_fails_legacy_datetime
  4. test_ts_write_fails_datetime_exception

These should be trivial to fix.

@mythrocks
Copy link
Collaborator

test_non_empty_ctas fails because of creating a table pointing to a non-empty directory:

E               pyspark.errors.exceptions.captured.AnalysisException: CREATE-TABLE-AS-SELECT cannot create table with location to a non-empty directory file:///tmp/pyspark_tests/pop-os-main-3128167-2117921863/CTAS/ctas. To allow overwriting the existing non-empty directory, set 'spark.sql.legacy.allowNonEmptyLocationInCTAS' to true.

I'll need to look at the tests more closely.

@mythrocks mythrocks removed their assignment Jul 24, 2024
@mythrocks
Copy link
Collaborator

Unassigning myself. I don't think I'll get to this in the next couple of weeks.

@razajafri
Copy link
Collaborator Author

Turning ANSI mode off we have the following failures with reasons

test_hive_timestamp_value (The SQL config 'spark.sql.legacy.parquet.datetimeRebaseModeInWrite' was removed in the version 4.0.0. Use 'spark.sql.parquet.datetimeRebaseModeInWrite' instead.)
test_non_empty_ctas (CREATE-TABLE-AS-SELECT cannot create table with location to a non-empty directory file:///tmp/pyspark_tests/a07cb15-lcedt-gw1-206777-597991485/CTAS/ctas. To allow overwriting the existing non-empty directory, set 'spark.sql.legacy.allowNonEmptyLocationInCTAS' to true.)
test_parquet_write_fails_legacy_datetime (The SQL config 'spark.sql.legacy.parquet.datetimeRebaseModeInWrite' was removed in the version 4.0.0. Use 'spark.sql.parquet.datetimeRebaseModeInWrite' instead.)
test_parquet_write_roundtrip_datetime_with_legacy_rebase (The SQL config 'spark.sql.legacy.parquet.int96RebaseModeInWrite' was removed in the version 4.0.0. Use 'spark.sql.parquet.int96RebaseModeInWrite' instead.)
test_ts_write_fails_datetime_exception (The SQL config 'spark.sql.legacy.parquet.datetimeRebaseModeInWrite' was removed in the version 4.0.0. Use 'spark.sql.parquet.datetimeRebaseModeInWrite' instead.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Spark 4.0+ Spark 4.0+ issues
Projects
None yet
Development

No branches or pull requests

3 participants