Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the BinaryOperator code wrt Decimal types #2077

Closed
razajafri opened this issue Apr 3, 2021 · 3 comments
Closed

Refactor the BinaryOperator code wrt Decimal types #2077

razajafri opened this issue Apr 3, 2021 · 3 comments
Assignees
@razajafri
Labels
task Work required that improves the product but is not user facing wontfix This will not be worked on

Comments

@razajafri
Copy link
Collaborator

Right now we have some repeated code in the arithmetic.scala for binary operations using decimal. We should refactor some of it so its simpler and easier to follow
@razajafri razajafri added feature request New feature or request ? - Needs Triage Need team to review and classify task Work required that improves the product but is not user facing labels Apr 3, 2021
@razajafri razajafri mentioned this issue Apr 3, 2021
Merged
@sameerz sameerz removed ? - Needs Triage Need team to review and classify feature request New feature or request labels Apr 6, 2021
@kuhushukla
Copy link
Collaborator

@razajafri Can you elaborate on this a bit? Thanks for the report.

@razajafri razajafri self-assigned this Jan 7, 2022
@razajafri
Copy link
Collaborator Author

@razajafri Can you elaborate on this a bit? Thanks for the report.

This might be stale after all the good work that's been put in for Decimal 128, but I will look at this and update ASAP

@razajafri
Copy link
Collaborator Author

I couldn't find any occurrence of repeated code that I saw earlier. Looks like it was handled while working on the Decimal 128 work

@sameerz sameerz added the wontfix This will not be worked on label Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@razajafri razajafri

Labels
task Work required that improves the product but is not user facing wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sameerz @razajafri @kuhushukla