Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Report gpuOpTime not totalTime for expand, generate, and range execs #2512

Closed
andygrove opened this issue May 26, 2021 · 0 comments · Fixed by #2513
Closed

[FEA] Report gpuOpTime not totalTime for expand, generate, and range execs #2512

andygrove opened this issue May 26, 2021 · 0 comments · Fixed by #2513
Assignees
Labels
feature request New feature or request

Comments

@andygrove
Copy link
Contributor

Is your feature request related to a problem? Please describe.
See #2334 for the motivation for this. This issue is to update metrics for a number of operators to report their current metric as gpuOpTime instead of totalTime, since the current metric they are using is purely the cost of applying the operation on the GPU and does not include any costs of executing or fetching data from child operators.

  • GpuExpandExec
  • GpuGenerateExec
  • GpuRangeExec

Describe the solution you'd like
Report gpuOpTime instead of totalTime.

Describe alternatives you've considered
None

Additional context
None

@andygrove andygrove added feature request New feature or request ? - Needs Triage Need team to review and classify labels May 26, 2021
@andygrove andygrove added this to the May 24 - Jun 4 milestone May 26, 2021
@andygrove andygrove self-assigned this May 26, 2021
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants