Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] CAST string to float/double produces incorrect results in some cases #2900

Closed
andygrove opened this issue Jul 9, 2021 · 0 comments · Fixed by #2933
Closed

[BUG] CAST string to float/double produces incorrect results in some cases #2900

andygrove opened this issue Jul 9, 2021 · 0 comments · Fixed by #2933
Assignees
@andygrove
Labels
bug Something isn't working
Milestone
July 19 - July 30

Comments

@andygrove
Copy link
Contributor

andygrove commented Jul 9, 2021 •
edited
Loading

Describe the bug
Casting string to float produces incorrect results in some cases. Examples:

Input CPU GPU
0260995.3E\r\t null 260995.3
e null 0
-1e\n null -1.0
5f 5.0 null

Steps/Code to reproduce bug
Discovered by running the fuzz tests in #2898

Expected behavior
CPU and GPU should produce the same results
@andygrove andygrove added bug Something isn't working ? - Needs Triage Need team to review and classify labels Jul 9, 2021
@andygrove andygrove added this to the July 5 - July 16 milestone Jul 9, 2021
@andygrove andygrove self-assigned this Jul 9, 2021
@Salonijain27 Salonijain27 removed the ? - Needs Triage Need team to review and classify label Jul 13, 2021
@andygrove andygrove mentioned this issue Jul 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andygrove andygrove

Labels
bug Something isn't working
Projects
None yet
Milestone
July 19 - July 30
Development

Successfully merging a pull request may close this issue.

Improve CAST string to float implementation to handle more edge cases andygrove/spark-rapids
3 participants
@andygrove @sameerz @Salonijain27