Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Support Maps, Lists, and Structs as non-key columns on joins #3116

Closed
revans2 opened this issue Aug 3, 2021 · 0 comments · Fixed by #3612
Closed

[FEA] Support Maps, Lists, and Structs as non-key columns on joins #3116

revans2 opened this issue Aug 3, 2021 · 0 comments · Fixed by #3612
Assignees
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request

Comments

@revans2
Copy link
Collaborator

revans2 commented Aug 3, 2021

Is your feature request related to a problem? Please describe.
Joins should generally work out of the box for all non key columns that cudf can gather (which should be everything that we can also support).

We have run into a few issues when testing this.
rapidsai/cudf#8938
rapidsai/cudf#8929

The first is a blocker. The second is a corner case that would be good to fix, but is not that likely to show up outside of a specially crafted test.

Describe the solution you'd like
Enable Maps, Lists and Structs as non-key columns in BroadcastExchangeExec (only broadcast join uses this right now), BroadcastJoin, ShuffledHashJoin, SortMergeJoin, BroadcastNestedLoopJoin, and CartesianProduct. This should include adding tests for them too, which mostly should be extending existing tests.

@revans2 revans2 added feature request New feature or request ? - Needs Triage Need team to review and classify labels Aug 3, 2021
@sameerz sameerz added cudf_dependency An issue or PR with this label depends on a new feature in cudf and removed ? - Needs Triage Need team to review and classify labels Aug 3, 2021
@nartal1 nartal1 self-assigned this Sep 8, 2021
@sameerz sameerz linked a pull request Sep 23, 2021 that will close this issue
@nartal1 nartal1 closed this as completed Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants