Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Support GpuFirst and GpuLast on nested types under reduction aggregations #3221

Closed
sperlingxx opened this issue Aug 12, 2021 · 3 comments · Fixed by #4337
Closed

[FEA] Support GpuFirst and GpuLast on nested types under reduction aggregations #3221

sperlingxx opened this issue Aug 12, 2021 · 3 comments · Fixed by #4337
Assignees
@sperlingxx
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request

Comments

@sperlingxx
Copy link
Collaborator

sperlingxx commented Aug 12, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
GpuFirst and GpuLast support nested types, but only in group by aggregations. They don't support nested types under reduction aggregations, because nested scalars are not supported by cuDF.
@sperlingxx sperlingxx added feature request New feature or request ? - Needs Triage Need team to review and classify labels Aug 12, 2021
@Salonijain27 Salonijain27 added cudf_dependency An issue or PR with this label depends on a new feature in cudf and removed ? - Needs Triage Need team to review and classify labels Aug 17, 2021
@Salonijain27
Copy link
Contributor

cuDF PR rapidsai/cudf#9043

@GaryShen2008
Copy link
Collaborator

@Salonijain27 Should we remove it from 21.10? It's not in PRD.

@sperlingxx
Copy link
Collaborator Author

sperlingxx commented Dec 6, 2021 •
edited
Loading

Fixed a cuDF bug rapidsai/cudf#9759 which broking this feature

@sperlingxx sperlingxx mentioned this issue Dec 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sperlingxx sperlingxx

Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support GpuFirst and GpuLast on nested types under reduction aggregations sperlingxx/spark-rapids
3 participants
@sperlingxx @GaryShen2008 @Salonijain27