Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] regexp_replace: Improve support for ^ and $ #4091

Closed
andygrove opened this issue Nov 12, 2021 · 0 comments · Fixed by #4155
Closed

[FEA] regexp_replace: Improve support for ^ and $ #4091

andygrove opened this issue Nov 12, 2021 · 0 comments · Fixed by #4155
Assignees
@andygrove
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request P1 Nice to have for release

Comments

@andygrove
Copy link
Contributor

andygrove commented Nov 12, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
Once #4063 is merged, we support regexp_replace on GPU but we fall back to CPU whenever the pattern contains the BOL/EOL anchors ^ and $.

Describe the solution you'd like
We should be able to support these anchors in some cases.

Describe alternatives you've considered
None

Additional context
Depends on rapidsai/cudf#9845
@andygrove andygrove added feature request New feature or request ? - Needs Triage Need team to review and classify labels Nov 12, 2021
@andygrove andygrove mentioned this issue Nov 12, 2021
Merged
@Salonijain27 Salonijain27 added P1 Nice to have for release and removed ? - Needs Triage Need team to review and classify labels Nov 16, 2021
@andygrove andygrove self-assigned this Nov 17, 2021
@andygrove andygrove added this to the Nov 15 - Nov 26 milestone Nov 17, 2021
@andygrove andygrove mentioned this issue Nov 18, 2021
Merged
@andygrove andygrove added the cudf_dependency An issue or PR with this label depends on a new feature in cudf label Dec 6, 2021
@andygrove andygrove removed this from the Nov 30 - Dec 10 milestone Dec 8, 2021
@andygrove andygrove mentioned this issue Jan 12, 2022
Open
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andygrove andygrove

Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request P1 Nice to have for release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add partial support for line begin and end anchors in regexp_replace andygrove/spark-rapids
2 participants
@andygrove @Salonijain27