Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] GpuCast crashes when casting from Array with unsupportable child type #4446

Closed
sperlingxx opened this issue Dec 31, 2021 · 0 comments · Fixed by #4449
Closed

[BUG] GpuCast crashes when casting from Array with unsupportable child type #4446

sperlingxx opened this issue Dec 31, 2021 · 0 comments · Fixed by #4449
Assignees
Labels
bug Something isn't working

Comments

@sperlingxx
Copy link
Collaborator

Describe the bug
Currently, GpuCast will crash with cuDF exception when we try to cast from ArrayType which holds an inconvertable child type towards the cast target.

Steps/Code to reproduce bug
Cast Array of Map to String with GPU enabled

Expected behavior
In my opinion, compared with adding a P.S. note in the user documentation, a better approach is to verify child types of Array in CastExprMeta.recursiveTagExprForGpuCheck, falling back the Cast expression to CPU if there exists non-replaceable type pairs. It will prevent the crash of GpuCast from the misbehaviors of users.

@sperlingxx sperlingxx added bug Something isn't working ? - Needs Triage Need team to review and classify labels Dec 31, 2021
@sameerz sameerz added this to the Dec 13 - Jan 7 milestone Jan 1, 2022
@jlowe jlowe changed the title [BUG] GpuCast crashs when casting from Array with unsupportable child type [BUG] GpuCast crashes when casting from Array with unsupportable child type Jan 4, 2022
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants