Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Support repetition quantifiers ? and * with regexp_replace #4468

Closed
andygrove opened this issue Jan 6, 2022 · 1 comment · Fixed by #5450
Closed

[FEA] Support repetition quantifiers ? and * with regexp_replace #4468

andygrove opened this issue Jan 6, 2022 · 1 comment · Fixed by #5450
Assignees
Labels
feature request New feature or request

Comments

@andygrove
Copy link
Contributor

andygrove commented Jan 6, 2022

Is your feature request related to a problem? Please describe.
We currently fall back to CPU for repetition quantifiers ? and * with regexp_replace because the behavior is not consistent with Spark.

For example, regexp_replace('a', '\D?', '_REPLACE_') produces _REPLACE__REPLACE_ on CPU, and _REPLACE_ on GPU.

Describe the solution you'd like
Make the behavior consistent with Spark and enable this on GPU.

Describe alternatives you've considered
None

Additional context
None

@NVnavkumar
Copy link
Collaborator

Confirmed that the same behavior happens with {0,} and {0,n} repetitions as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants