Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Build failures against Spark 3.2.1 rc1 and make 3.2.1 non snapshot #4500

Closed
tgravescs opened this issue Jan 11, 2022 · 4 comments · Fixed by #4508
Closed

[BUG] Build failures against Spark 3.2.1 rc1 and make 3.2.1 non snapshot #4500

tgravescs opened this issue Jan 11, 2022 · 4 comments · Fixed by #4508
Assignees
Labels
bug Something isn't working P0 Must have for release

Comments

@tgravescs
Copy link
Collaborator

Describe the bug
I was building against the spark 3.2.1 rc1 that is up for vote and got some build failures:

[ERROR] [Error] /home/tgraves/workspace/spark-rapids/sql-plugin/src/main/320until322/scala/com/nvidia/spark/rapids/shims/v2/Spark320until322Shims.scala:40: value datetimeRebaseMode is not a member of object org.apache.spark.sql.execution.datasources.DataSourceUtils
possible cause: maybe a semicolon is missing before `value datetimeRebaseMode'?
[ERROR] [Error] /home/tgraves/workspace/spark-rapids/sql-plugin/src/main/320until322/scala/org/apache/spark/sql/execution/datasources/parquet/rapids/shims/v2/ShimVectorizedColumnReader.scala:43: type mismatch;
 found   : org.apache.spark.sql.internal.SQLConf.LegacyBehaviorPolicy.Value
 required: org.apache.spark.sql.catalyst.util.RebaseDateTime.RebaseSpec
[INFO] [Info] : org.apache.spark.sql.internal.SQLConf.LegacyBehaviorPolicy.Value <: org.apache.spark.sql.catalyst.util.RebaseDateTime.RebaseSpec?
[INFO] [Info] : false
[ERROR] [Error] /home/tgraves/workspace/spark-rapids/sql-plugin/src/main/320until322/scala/org/apache/spark/sql/execution/datasources/parquet/rapids/shims/v2/ShimVectorizedColumnReader.scala:44: type mismatch;
 found   : org.apache.spark.sql.internal.SQLConf.LegacyBehaviorPolicy.Value
 required: org.apache.spark.sql.catalyst.util.RebaseDateTime.RebaseSpec
[INFO] [Info] : org.apache.spark.sql.internal.SQLConf.LegacyBehaviorPolicy.Value <: org.apache.spark.sql.catalyst.util.RebaseDateTime.RebaseSpec?
[INFO] [Info] : false
[ERROR] [Error] /home/tgraves/workspace/spark-rapids/sql-plugin/src/main/320until322/scala/org/apache/spark/sql/execution/datasources/parquet/rapids/shims/v2/ShimVectorizedColumnReader.scala:56: not enough arguments for constructor VectorizedColumnReader: (x$1: org.apache.parquet.column.ColumnDescriptor, x$2: org.apache.parquet.schema.LogicalTypeAnnotation, x$3: org.apache.parquet.column.page.PageReader, x$4: java.util.PrimitiveIterator.OfLong, x$5: java.time.ZoneId, x$6: String, x$7: String, x$8: String, x$9: String)org.apache.spark.sql.execution.datasources.parquet.VectorizedColumnReader.
Unspecified value parameters x$8, x$9.
[ERROR] four errors found

Looks like the datetimeRebase mode caused by https://issues.apache.org/jira/browse/SPARK-37705

@tgravescs tgravescs added bug Something isn't working ? - Needs Triage Need team to review and classify labels Jan 11, 2022
@tgravescs tgravescs self-assigned this Jan 11, 2022
@tgravescs
Copy link
Collaborator Author

Note this was initially handled for 3.3.0 and 3.2.2 in 9281caa#diff-91b290931d42094ddbdde567e494e940cfb9c53cbbbe1f679eaa3b513afe2723

and #4465

But it looks like our build wasn't fully up to date due tot the way the spark release candidate version was already incremented.

@tgravescs tgravescs added P0 Must have for release ? - Needs Triage Need team to review and classify and removed ? - Needs Triage Need team to review and classify labels Jan 11, 2022
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Jan 11, 2022
@sameerz sameerz added this to the Jan 10 - Jan 28 milestone Jan 11, 2022
@Niharikadutta
Copy link

@tgravescs Do we have a working change ready for this? We are seeing these issues while building against Spark 3.2.1.

@jlowe
Copy link
Member

jlowe commented Jan 25, 2022

@Niharikadutta yes, the linked PR #4508 should resolve the issue.

@tgravescs
Copy link
Collaborator Author

pr merged

@tgravescs tgravescs changed the title [BUG] Build failures against Spark 3.2.1 rc1 [BUG] Build failures against Spark 3.2.1 rc1 and make 3.2.1 non snapshot Jan 28, 2022
@pxLi pxLi changed the title [BUG] Build failures against Spark 3.2.1 rc1 and make 3.2.1 non snapshot [BUG] Build failures against Spark 3.2.1 rc1 and make 3.2.1 non snapshot Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P0 Must have for release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants