Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Improve detection of regexp patterns that cuDF cannot compile #4603

Closed
andygrove opened this issue Jan 21, 2022 · 0 comments · Fixed by #6013
Closed

[BUG] Improve detection of regexp patterns that cuDF cannot compile #4603

andygrove opened this issue Jan 21, 2022 · 0 comments · Fixed by #6013
Assignees
Labels
bug Something isn't working

Comments

@andygrove
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The AST-based regex fuzz tests currently does not test choices (|) because it can generate patterns that cuDF does not support and that we do not detect as unsupported. I would like us to improve the logic to catch these cases so that we can enable choices in the fuzz tests to improve coverage.

Here is an example of an error that occurs when choices are enabled:

cuDF failed to compile pattern: \A| 

Describe the solution you'd like
Improve logic for detecting uncompilable patterns and enable choice in fuzz tests.

Describe alternatives you've considered
None

Additional context
None

@andygrove andygrove added feature request New feature or request ? - Needs Triage Need team to review and classify labels Jan 21, 2022
@sameerz sameerz added bug Something isn't working and removed ? - Needs Triage Need team to review and classify feature request New feature or request labels Jan 25, 2022
@sameerz sameerz changed the title [FEA] Improve detection of regexp patterns that cuDF cannot compile [BUG] Improve detection of regexp patterns that cuDF cannot compile Jan 25, 2022
@anthony-chang anthony-chang self-assigned this Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants