Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize DECIMAL128 average aggregations #4722

Closed
jlowe opened this issue Feb 8, 2022 · 0 comments · Fixed by #4776
Closed

Optimize DECIMAL128 average aggregations #4722

jlowe opened this issue Feb 8, 2022 · 0 comments · Fixed by #4776
Assignees
@jlowe
Labels
feature request New feature or request P1 Nice to have for release performance A performance related task/issue task Work required that improves the product but is not user facing

Comments

@jlowe
Copy link
Member

jlowe commented Feb 8, 2022

The optimizations for DECIMAL128 sum aggregations and overflow checking in #4688 should be applied to aggregations producing an average of DECIMAL128. Since average aggregations are a combination of sum aggregation and count aggregations, it should be relatively straightforward to adopt the same approach that was done for sum aggregations.
@jlowe jlowe added feature request New feature or request ? - Needs Triage Need team to review and classify performance A performance related task/issue task Work required that improves the product but is not user facing labels Feb 8, 2022
@sameerz sameerz added P1 Nice to have for release and removed ? - Needs Triage Need team to review and classify labels Feb 8, 2022
This was referenced Feb 8, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jlowe jlowe

Labels
feature request New feature or request P1 Nice to have for release performance A performance related task/issue task Work required that improves the product but is not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve aggregation performance of average on DECIMAL128 columns [databricks] jlowe/spark-rapids
2 participants
@jlowe @sameerz