Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration_tests test jar has integration test code split between src/main and src/test #4892

Closed
jlowe opened this issue Mar 2, 2022 · 1 comment · Fixed by #4904
Closed
Assignees
Labels
task Work required that improves the product but is not user facing test Only impacts tests

Comments

@jlowe
Copy link
Member

jlowe commented Mar 2, 2022

The integration_tests module has code in both src/main and src/test that is intended for testing the sql-plugin module. This is very confusing and has lead to problems in CI builds that assumed everything needed to perform the integration tests is in the integration_tests main jar, see #4890. Usually code in src/test/ is intended to test code within that module, and it's inconsistent to place code for integration testing the RAPIDS Accelerator in both integration_tests/src/main and integration_tests/src/test.

@jlowe jlowe added ? - Needs Triage Need team to review and classify test Only impacts tests task Work required that improves the product but is not user facing labels Mar 2, 2022
@revans2
Copy link
Collaborator

revans2 commented Mar 2, 2022

For background the split was originally intended so that src would produce a standalone jar that only depended on Spark. Then there would just be pure tests inside of the test directory that could depend on the plugin at runtime to be able to verify that things were working. I think that fits with what was described by @jlowe above and I hope we can return to that.

@pxLi pxLi closed this as completed in #4904 Mar 7, 2022
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Work required that improves the product but is not user facing test Only impacts tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants