Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Fall back to the CPU if we see a scale on Ceil or Floor #4913

Closed
revans2 opened this issue Mar 8, 2022 · 1 comment · Fixed by #4971
Closed

[BUG] Fall back to the CPU if we see a scale on Ceil or Floor #4913

revans2 opened this issue Mar 8, 2022 · 1 comment · Fixed by #4971
Assignees
@nartal1
Labels
audit_3.3.0 Audit related tasks for 3.3.0 bug Something isn't working P0 Must have for release
Milestone
Mar 21 - Apr 1

Comments

@revans2
Copy link
Collaborator

revans2 commented Mar 8, 2022

Describe the bug
#4910 showed that a new parameter, scale, was added to floor and ceil in 3.3. If we see a a scale that is not 0 we cannot support this and must fall back to the CPU to avoid data corruption. At least until we can add in support for it properly.
@revans2 revans2 added bug Something isn't working ? - Needs Triage Need team to review and classify P0 Must have for release audit_3.3.0 Audit related tasks for 3.3.0 labels Mar 8, 2022
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Mar 8, 2022
@nartal1 nartal1 self-assigned this Mar 9, 2022
@sameerz sameerz added this to the Feb 28 - Mar 18 milestone Mar 9, 2022
@nartal1 nartal1 mentioned this issue Mar 16, 2022
Merged
@wjxiz1992 wjxiz1992 mentioned this issue Mar 18, 2022
Closed
@tgravescs
Copy link
Collaborator

At least until we can add in support for it properly.

Do we have a follow on issue to add support for it or we were just going to wait for customer to request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nartal1 nartal1

Labels
audit_3.3.0 Audit related tasks for 3.3.0 bug Something isn't working P0 Must have for release
Projects
None yet
Milestone
Mar 21 - Apr 1
Development

Successfully merging a pull request may close this issue.

Fall back to the CPU for non-zero scale on Ceil or Floor functions [databricks] nartal1/spark-rapids
4 participants
@revans2 @tgravescs @sameerz @nartal1