Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There are references to non-existent shims dir that needs to be updated #4920

Closed
razajafri opened this issue Mar 9, 2022 · 3 comments
Closed

There are references to non-existent shims dir that needs to be updated #4920

razajafri opened this issue Mar 9, 2022 · 3 comments
Assignees
@pxLi @razajafri
Labels
build Related to CI / CD or cleanly building documentation Improvements or additions to documentation
Milestone
Mar 21 - Apr 1

Comments

@razajafri
Copy link
Collaborator 

git grep '[^/]shims/'
CONTRIBUTING.md:There is a known issue with the shims/spark3xx submodules. After being enabled once, a module such as shims/spark312
docs/dev/shims.md:(i.e., in `sql-plugin/src/main/scala` as opposed to be duplicated either in `shims/spark3xx` submodules or over
jenkins/Jenkinsfile-blossom.premerge:                                                                      'sql-plugin/src/main/scala/,shims/spark311/src/main/scala/,' +
jenkins/Jenkinsfile-blossom.premerge:                                                                      'shims/spark301db/src/main/scala/,shims/spark301/src/main/scala/,' +
jenkins/Jenkinsfile-blossom.premerge:                                                                      'shims/spark302/src/main/scala/,shims/spark303/src/main/scala/,' +
jenkins/Jenkinsfile-blossom.premerge:                                                                      'shims/spark304/src/main/scala/,shims/spark312/src/main/scala/,' +
jenkins/Jenkinsfile-blossom.premerge:                                                                      'shims/spark313/src/main/scala/'

Originally posted by @gerashegalov in #4857 (comment)
@razajafri razajafri self-assigned this Mar 9, 2022
@sameerz sameerz added the documentation Improvements or additions to documentation label Mar 9, 2022
@tgravescs tgravescs added the build Related to CI / CD or cleanly building label Mar 10, 2022
@razajafri razajafri mentioned this issue Mar 22, 2022
Closed
@razajafri
Copy link
Collaborator Author

@pxLi is assigned to an issue #4991 which should handle the references to non-existent shims/spark* folders. I will address the changes in .md file

@razajafri razajafri mentioned this issue Mar 22, 2022
Merged
@razajafri
Copy link
Collaborator Author

I am limiting this issue to only address the references in .md files

The jacoco references in Jenkinsfile-blossom.premerge will be addressed by #4991

@pxLi pxLi mentioned this issue Mar 28, 2022
Merged
@sameerz sameerz added this to the Mar 21 - Apr 1 milestone Mar 28, 2022
@pxLi
Copy link
Collaborator

pxLi commented Mar 30, 2022

#5067

@pxLi pxLi closed this as completed Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pxLi pxLi

@razajafri razajafri

Labels
build Related to CI / CD or cleanly building documentation Improvements or additions to documentation
Projects
None yet
Milestone
Mar 21 - Apr 1
Development

No branches or pull requests
4 participants
@tgravescs @sameerz @pxLi @razajafri