Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Premerge CI should automatically run on Databricks if code touches Databricks shims #5049

Closed
jlowe opened this issue Mar 25, 2022 · 2 comments
Closed

Premerge CI should automatically run on Databricks if code touches Databricks shims #5049

jlowe opened this issue Mar 25, 2022 · 2 comments
Assignees
@pxLi
Labels
build Related to CI / CD or cleanly building task Work required that improves the product but is not user facing

Comments

@jlowe
Copy link
Member

jlowe commented Mar 25, 2022

We currently have the ability to opt-in for Databricks runs in premerge CI with the [databricks] tag, but the developer has to remember to use it. It would be nice if premerge automatically ran on Databricks if there are any changes to files in the Databricks shims, i.e.: code that only builds on Databricks instances. Currently this would apply to any PR that has file paths matching against these regexp patterns:

  • sql-plugin/src/main/.*[0-9x-]db/
  • databricks
@jlowe jlowe added ? - Needs Triage Need team to review and classify build Related to CI / CD or cleanly building task Work required that improves the product but is not user facing labels Mar 25, 2022
@pxLi pxLi self-assigned this Mar 28, 2022
@pxLi pxLi removed the ? - Needs Triage Need team to review and classify label Mar 28, 2022
@pxLi
Copy link
Collaborator

pxLi commented Mar 28, 2022

nice, this is on my TODO list. I will enable the auto-trigger of above patterns later

@pxLi pxLi mentioned this issue Mar 28, 2022
Merged
@pxLi
Copy link
Collaborator

pxLi commented Mar 30, 2022

#5067

@pxLi pxLi closed this as completed Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pxLi pxLi

Labels
build Related to CI / CD or cleanly building task Work required that improves the product but is not user facing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlowe @pxLi