Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Support Key vectors for GetMapValue and ElementAt for maps. #5204

Closed
mythrocks opened this issue Apr 12, 2022 · 3 comments
Closed

[FEA] Support Key vectors for GetMapValue and ElementAt for maps. #5204

mythrocks opened this issue Apr 12, 2022 · 3 comments
Assignees
@razajafri
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request

Comments

@mythrocks
Copy link
Collaborator

This is a follow-up for #5180.

#4944 added support for non-string types in GetMapValue and ElementAt. This feature currently supports only scalar values as keys.

It would be good to extend this support to key vectors, so that expressions might be used as map keys. This will require support in libcudf and JNI.
@mythrocks mythrocks added feature request New feature or request ? - Needs Triage Need team to review and classify labels Apr 12, 2022
@mythrocks mythrocks mentioned this issue Apr 12, 2022
Closed
@sameerz sameerz added cudf_dependency An issue or PR with this label depends on a new feature in cudf and removed ? - Needs Triage Need team to review and classify labels Apr 12, 2022
@sameerz sameerz mentioned this issue May 3, 2022
Closed
@mythrocks mythrocks mentioned this issue May 10, 2022
Closed
@razajafri razajafri self-assigned this May 20, 2022
@razajafri
Copy link
Collaborator

To support ANSI mode, we need contains(ColumnVector) to be supported in cudf

@sameerz
Copy link
Collaborator

sameerz commented Jun 25, 2022

To support ANSI mode, we need contains(ColumnVector) to be supported in cudf

Is there a cudf issue for contains(ColumnVector), if not, can you please file one?

@razajafri
Copy link
Collaborator

Fixed by #5883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@razajafri razajafri

Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mythrocks @sameerz @razajafri