Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Migrate most regexp scala tests to pytest integration tests #5488

Open
NVnavkumar opened this issue May 13, 2022 · 0 comments
Open

[TASK] Migrate most regexp scala tests to pytest integration tests #5488

NVnavkumar opened this issue May 13, 2022 · 0 comments
Labels
test Only impacts tests

Comments

@NVnavkumar
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Scala unit tests in the build process do not run in parallel, and therefore slow down the build process. Also, Scala tests are only testing on the unit level and testing against the pure JVM version of regular expressions, which Spark does follow for the most part, except for a few exceptions (see REGEXP_REPLACE(...) which has a position parameter, but Java does not, so this incurs special handling and potential bugs like https://issues.apache.org/jira/browse/SPARK-39107).

Describe the solution you'd like
We should migrate these to integration tests for performance reasons in the build process and for correctness against Spark as a whole as opposed to just versus the JVM.

@NVnavkumar NVnavkumar added feature request New feature or request ? - Needs Triage Need team to review and classify labels May 13, 2022
@sameerz sameerz added test Only impacts tests and removed feature request New feature or request ? - Needs Triage Need team to review and classify labels May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

No branches or pull requests

2 participants