Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Investigate regexp failures with unicode input #5521

Closed
andygrove opened this issue May 17, 2022 · 2 comments
Closed

[BUG] Investigate regexp failures with unicode input #5521

andygrove opened this issue May 17, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@andygrove
Copy link
Contributor

andygrove commented May 17, 2022

Describe the bug
Investigate regexp issue discovered during testing #5450

The following test failed in CI but could not be reproduced locally. The issue appears to be specific to the superscript character ¹.

  test("issue 5450 ci failure") {
    val pattern = Seq("D?")
    val inputs = Seq("\u000E\u0011\u0006h¹TEST\ud720AA")
    assertCpuGpuMatchesRegexpReplace(pattern, inputs)
  }

Steps/Code to reproduce bug
See above.

Expected behavior
Behavior should be consistent between CPU and GPU or we should fall back to CPU.

Environment details (please complete the following information)
Failed in CI.

Additional context
None

@andygrove andygrove added bug Something isn't working ? - Needs Triage Need team to review and classify labels May 17, 2022
@andygrove andygrove added this to the May 2 - May 20 milestone May 17, 2022
@andygrove andygrove self-assigned this May 17, 2022
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label May 17, 2022
@andygrove andygrove changed the title [BUG] Investigate regexp failures related to superscript character [BUG] Investigate regexp failures with unicode input May 18, 2022
@anthony-chang anthony-chang self-assigned this May 18, 2022
@andygrove
Copy link
Contributor Author

This should get fixed by #5627

@sameerz sameerz modified the milestones: May 23 - Jun 3, Jun 6 - Jun 17 Jun 8, 2022
@sameerz sameerz removed this from the Jun 6 - Jun 17 milestone Jun 18, 2022
@andygrove andygrove removed their assignment Jul 8, 2022
@anthony-chang
Copy link
Contributor

Fixed with #5776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants