Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Support RoundCeil and RoundFloor when scale is zero #5797

Closed
nartal1 opened this issue Jun 9, 2022 · 0 comments · Fixed by #5804
Closed

[FEA] Support RoundCeil and RoundFloor when scale is zero #5797

nartal1 opened this issue Jun 9, 2022 · 0 comments · Fixed by #5804
Assignees
Labels
feature request New feature or request

Comments

@nartal1
Copy link
Collaborator

nartal1 commented Jun 9, 2022

Is your feature request related to a problem? Please describe.
We have currently disabled running RoundCeil and RoundFloor expressions on GPU and fall back to CPU for all inputs. We can enable it for scale=0 as it would call GpuCeil/GpuFloor internally. There is a bug where it produces incorrect results when the input type is DecimalType(precision = 18, scale = 0) .
We should enable these integration tests to verify:

  1. test_floor_scale_zero
  2. test_ceil_scale_zero
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants