Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Cross Join should handle RetryOOM exceptions #8097

Closed
jbrennan333 opened this issue Apr 13, 2023 · 1 comment
Closed

[FEA] Cross Join should handle RetryOOM exceptions #8097

jbrennan333 opened this issue Apr 13, 2023 · 1 comment
Assignees
Labels
invalid This doesn't seem right reliability Features to improve reliability or bugs that severly impact the reliability of the plugin

Comments

@jbrennan333
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
This is a follow-on to the work done for #7255. The CrossJoinIterator derives from AbstractGpuJoinIterator, but overrides setupNextGatherer, so it does not benefit from the changes related to creating the gatherer. It does benefit from the changes related to gatherNext, getting the next batch from the gatherer.

We should add OOM retries to handle the createGatherer case in CrossJoinIterator.

Describe the solution you'd like
This work should be very similar to what was done for #7255. Add withRetry blocks to handle cases where we may be doing large allocations.

@jbrennan333 jbrennan333 added feature request New feature or request reliability Features to improve reliability or bugs that severly impact the reliability of the plugin labels Apr 13, 2023
@jbrennan333 jbrennan333 self-assigned this Apr 13, 2023
@jbrennan333
Copy link
Collaborator Author

This is not needed. CrossJoinIterator does not do any GPU allocations while setting up the gatherer.
All of the work is done in BaseCrossJoinGatherMap.toColumnView, which is part of the gatherNext processing, and is covered by the changes to AbstractGpuJoinIterator.nextCbFromGatherer in #7930. Closing this one.

@sameerz sameerz added invalid This doesn't seem right and removed feature request New feature or request labels Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right reliability Features to improve reliability or bugs that severly impact the reliability of the plugin
Projects
None yet
Development

No branches or pull requests

2 participants