Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delta Lake 2.4 missing equals/hashCode override for file format and some metrics for merge #9581

Closed
jlowe opened this issue Oct 30, 2023 · 0 comments · Fixed by #9586
Closed

Delta Lake 2.4 missing equals/hashCode override for file format and some metrics for merge #9581

jlowe opened this issue Oct 30, 2023 · 0 comments · Fixed by #9586
Assignees
@jlowe
Labels
bug Something isn't working

Comments

@jlowe
Copy link
Member

jlowe commented Oct 30, 2023

Per the review of #9562 there are some things in the Delta Lake 2.4 support that should be addressed:

  • No equals/hashCode override for GpuDelta24xParquetFileFormat like there is for Delta Lake 2.4's DeltaParquetFileFormat
  • Missing targetRowsUpdated, targetRowsMatchedUpdated metrics
@jlowe jlowe added the ? - Needs Triage Need team to review and classify label Oct 30, 2023
@jlowe jlowe self-assigned this Oct 30, 2023
This was referenced Oct 30, 2023
Merged
Merged
@mattahrens mattahrens added bug Something isn't working and removed ? - Needs Triage Need team to review and classify labels Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jlowe jlowe

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge metrics and file format fixes to Delta 2.4 support jlowe/spark-rapids
2 participants
@jlowe @mattahrens