Searching via API using the search term '0' without asterisk (0*) fails

[miguelvaara]

At which URL did you encounter the problem?

https://api.dev.finto.fi/rest/v1/ykl/search?query=0

What steps will reproduce the problem?

1. Go https://api.finto.fi/rest/v1/ykl/search?query=0

What is the expected output? What do you see instead?

It turned out that the fixes in the PR #1261 do not work completely (mostly it works 👍 ). There is still a problem with the searches with zeros ('0') if you do not use a trailing asterisk with the number zero.

https://api.finto.fi/rest/v1/ykl/search?query=0 should return a result containing the concept https://dev.finto.fi/ykl/en/page/0 (http://urn.fi/URN:NBN:fi:au:ykl:0) but it returns an empty result.

What browser did you use? (eg. Firefox, Chrome, Safari, Internet explorer)

FF

[kinow]

The issue description has URLs to dev.finto and to finto. The version in finto is a little behind, so it will display an older bug, saying that the query parameter is missing.

should return a result containing the concept https://dev.finto.fi/ykl/en/page/0 (http://urn.fi/URN:NBN:fi:au:ykl:0) but it returns an empty result.

👍 if I search for 00 it works. 00.1 also brings the right results. But 0 is not returning the concept above 😕

[kinow]

Found the 🐛 :

Skosmos/model/ConceptSearchParameters.php

Line 71 in 841dc1b

if (!$term && $this->rest)

When query=0, the !$term evaluates to true, and it uses label instead. You can test with the URL: https://api.dev.finto.fi/rest/v1/ykl/search?query=0&label=0

PR with the fix on its way... 🏃