Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"show all X paths" message misplaced when concept has many paths #1355

Closed
osma opened this issue Sep 7, 2022 · 3 comments · Fixed by #1357
Closed

"show all X paths" message misplaced when concept has many paths #1355

osma opened this issue Sep 7, 2022 · 3 comments · Fixed by #1357
Labels
Milestone

Comments

@osma
Copy link
Member

osma commented Sep 7, 2022

At which URL did you encounter the problem?

https://finto.fi/koko/en/page/p32086

What steps will reproduce the problem?

  1. Go to a concept with many (>4) paths in the hierarchy (e.g. above URL)

What is the expected output? What do you see instead?

Expected to see four possible breadcrumb paths and the [show all X paths] link below them. Instead, the message appears in between the first and second paths:

image

This was likely caused by the Bootstrap 5 upgrade (ping @kinow)

(originally found by @kouralex )

What browser did you use? (eg. Firefox, Chrome, Safari, Internet explorer)

Firefox

@osma osma added the bug label Sep 7, 2022
@kinow
Copy link
Collaborator

kinow commented Sep 7, 2022

Huh, looks like the code is skipping 4 breadcrumbs, then hiding everything.

Screenshot from 2022-09-07 18-30-52

But then it indeed adds the link to show more breadcrumbs after the first link.

Screenshot from 2022-09-07 18-31-45

Should be easy to fix 👍 Will try to prepare a PR soon.

@kinow
Copy link
Collaborator

kinow commented Sep 7, 2022

@osma

I manually removed the HTML node with that link. Then executed the code with the possible fix. Is this the correct location?

image

The formatting is looking different than the breadcrumbs. Should I change that too?

I also couldn't find the commit that broke it. It appears to be adding the link after the first element already for some time - 018fdc8. But maybe the new CSS rules broke it or made it more visible.

-Bruno

@osma
Copy link
Member Author

osma commented Sep 7, 2022

Ah, hm. I probably misremembered the location. It's actually been on the right side of the paths, in the top right corner. Maybe there were some CSS rules placing it there that were lost in the Bootstrap 5 upgrade?

And yes, the font size and other styling should be the same as for the breadcrumbs - now the text looks bigger than it should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants