Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reveal hiddenLabels that were used for matching #434

Closed
osma opened this issue Jan 20, 2016 · 3 comments
Closed

Don't reveal hiddenLabels that were used for matching #434

osma opened this issue Jan 20, 2016 · 3 comments
Milestone

Comments

@osma
Copy link
Member

osma commented Jan 20, 2016

Currently when a user performs a search that matches via a hiddenLabel (e.g. "joki" matches "joet" in YSO and "helsinki kallio" matches "Helsinki -- Kallio" in YSA), the autocomplete box shows which hiddenLabel was matched:

yso-joki-autocomplete

It might be better to show just the real label of the concept ("joet" in this case) and not reveal the hidden label at all.

@osma osma added this to the Next Tasks milestone Jan 20, 2016
@osma
Copy link
Member Author

osma commented Jan 20, 2016

Same applies also to the search result list:
yso-joki-search

@osma
Copy link
Member Author

osma commented Feb 16, 2016

But the hit via hiddenLabel shouldn't be shown at all in the autocomplete lists if there is another kind of match to the same concept (prefLabel or altLabel).

@osma osma added size-medium 2 hours to 2 days and removed size-small max 2 hours labels Feb 16, 2016
@osma osma modified the milestones: Next Tasks, 1.7 Feb 16, 2016
@osma osma self-assigned this Apr 26, 2016
@osma
Copy link
Member Author

osma commented Apr 28, 2016

I've tried to come up with a way of implementing this in the SPARQL queries, but I can't figure it out. A possible alternative would be to post-process results of the search method call in JavaScript.

@osma osma removed their assignment Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant