Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URIs with pattern "<void:uriSpace>/something/ID" do not work properly in tree #652

Closed
tfrancart opened this issue Nov 6, 2017 · 1 comment
Labels
Milestone

Comments

@tfrancart
Copy link
Contributor

  1. void:uriSpace is specified as http://exemple.com/thesaurus/.
  2. SKOS data contains collections with URI http://exemple.com/thesaurus/collection/c1
  3. In the "Groups" tab, Skosmos generates a link "http://myserver.fr/skosmos/fr/page/collection/c1, which do no work.

In hierarchy.js::getConceptHref(), an extra test should be added to check if the end of the URI does not contain additionnal slashes. If this is the case, default to a "...?uri=..." link.

I will propose a PR.

@osma osma added the bug label Nov 6, 2017
@osma
Copy link
Member

osma commented Nov 6, 2017

Thanks, good catch!

@osma osma added this to the 1.10 milestone Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants