From f52cbea724c480f7acfcaf1204b5e285ff246424 Mon Sep 17 00:00:00 2001
From: NejcZdovc <nejc.zdovc@3zsistemi.si>
Date: Wed, 7 Jun 2017 16:13:51 -0700
Subject: [PATCH] Refactors PublisherToggle into redux component

Resolves #9323

Auditors: @bridiver @bscfliton

Test Plan:
---
 app/common/lib/publisherUtil.js               |  66 +++++++++
 app/common/state/siteSettingsState.js         |  17 +++
 .../components/navigation/navigationBar.js    |  77 ++++------
 .../components/navigation/publisherToggle.js  | 137 +++++++-----------
 app/renderer/components/navigation/urlBar.js  |  19 +--
 test/unit/app/common/lib/publisherUtilTest.js |  71 +++++++++
 .../navigation/publisherToggleTest.js         |   2 +-
 7 files changed, 243 insertions(+), 146 deletions(-)
 create mode 100644 app/common/lib/publisherUtil.js
 create mode 100644 test/unit/app/common/lib/publisherUtilTest.js

diff --git a/app/common/lib/publisherUtil.js b/app/common/lib/publisherUtil.js
new file mode 100644
index 00000000000..3629c42d47d
--- /dev/null
+++ b/app/common/lib/publisherUtil.js
@@ -0,0 +1,66 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this file,
+ * You can obtain one at http://mozilla.org/MPL/2.0/. */
+
+const Immutable = require('immutable')
+
+// Constants
+const settings = require('../../../js/constants/settings')
+const siteSettingsState = require('../state/siteSettingsState')
+
+// Utils
+const {getSetting} = require('../../../js/settings')
+const {isHttpOrHttps} = require('../../../js/lib/urlutil')
+const {isSourceAboutUrl} = require('../../../js/lib/appUrlUtil')
+
+const visiblePublisher = (state, publisherId) => {
+  if (publisherId == null) {
+    return true
+  }
+
+  // ledgerPaymentsShown is undefined by default until
+  // user decide to permanently hide the publisher,
+  // so for icon to be shown it can be everything but false
+  const hostSettings = siteSettingsState.getSettingsByHost(state, publisherId)
+  const ledgerPaymentsShown = hostSettings && hostSettings.get('ledgerPaymentsShown')
+
+  return typeof ledgerPaymentsShown === 'boolean'
+    ? ledgerPaymentsShown
+    : true
+}
+
+const publisherState = {
+  enabledForPaymentsPublisher: (state, locationId) => {
+    const locationInfo = state.get('locationInfo', Immutable.Map())
+    const publisherId = locationInfo.getIn([locationId, 'publisher'])
+    const synopsis = state.getIn(['publisherInfo', 'synopsis'], Immutable.Map())
+    const hostSettings = siteSettingsState.getSettingsByHost(state, publisherId)
+
+    // All publishers will be enabled by default if AUTO_SUGGEST is ON,
+    // excluding publishers defined on ledger's exclusion list
+    const excluded = locationInfo.getIn([locationId, 'exclude'])
+    const autoSuggestSites = getSetting(settings.AUTO_SUGGEST_SITES)
+
+    // If session is clear then siteSettings is undefined and icon
+    // will never be shown, but synopsis may not be empty.
+    // In such cases let's check if synopsis matches current publisherId
+    const isValidPublisherSynopsis = !!synopsis.map(entry => entry.get('site'))
+      .includes(publisherId)
+
+    // hostSettings is undefined until user hit addFunds button.
+    // For such cases check autoSuggestSites for eligibility.
+    return hostSettings
+      ? hostSettings.get('ledgerPayments') !== false
+      : isValidPublisherSynopsis || (autoSuggestSites && !excluded)
+  },
+
+  shouldShowAddPublisherButton: (state, location, publisherId) => {
+    return location &&
+      !isSourceAboutUrl(location) &&
+      getSetting(settings.PAYMENTS_ENABLED) &&
+      isHttpOrHttps(location) &&
+      visiblePublisher(state, publisherId)
+  }
+}
+
+module.exports = publisherState
diff --git a/app/common/state/siteSettingsState.js b/app/common/state/siteSettingsState.js
index 6effa414577..c6b81a3d859 100644
--- a/app/common/state/siteSettingsState.js
+++ b/app/common/state/siteSettingsState.js
@@ -1,6 +1,16 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this file,
+ * You can obtain one at http://mozilla.org/MPL/2.0/. */
+
+// Constants
 const appConfig = require('../../../js/constants/appConfig')
+
+// State
 const siteSettings = require('../../../js/state/siteSettings')
 
+// Utils
+const {getHostPattern} = require('../../../js/lib/urlutil')
+
 const api = {
   getAllSiteSettings: (state, isPrivate) => {
     if (isPrivate) {
@@ -9,6 +19,13 @@ const api = {
     return state.get('siteSettings')
   },
 
+  getSettingsByHost: (state, url) => {
+    const siteSettings = state.get('siteSettings')
+    const hostPattern = getHostPattern(url)
+
+    return siteSettings.get(hostPattern)
+  },
+
   isNoScriptEnabled (state, settings) {
     return siteSettings.activeSettings(settings, state, appConfig).noScript === true
   }
diff --git a/app/renderer/components/navigation/navigationBar.js b/app/renderer/components/navigation/navigationBar.js
index 32f45623646..00b746bc0ad 100644
--- a/app/renderer/components/navigation/navigationBar.js
+++ b/app/renderer/components/navigation/navigationBar.js
@@ -24,6 +24,7 @@ const settings = require('../../../../js/constants/settings')
 
 // State
 const tabState = require('../../../common/state/tabState')
+const publisherState = require('../../../common/lib/publisherUtil')
 const frameStateUtil = require('../../../../js/state/frameStateUtil')
 
 // Store
@@ -31,7 +32,7 @@ const windowStore = require('../../../../js/stores/windowStore')
 
 // Utils
 const cx = require('../../../../js/lib/classSet')
-const {isSourceAboutUrl} = require('../../../../js/lib/appUrlUtil')
+const {getBaseUrl} = require('../../../../js/lib/appUrlUtil')
 const siteUtil = require('../../../../js/state/siteUtil')
 const eventUtil = require('../../../../js/lib/eventUtil')
 const UrlUtil = require('../../../../js/lib/urlutil')
@@ -55,7 +56,7 @@ class NavigationBar extends React.Component {
   }
 
   onToggleBookmark () {
-    const editing = this.bookmarked
+    const editing = this.props.isBookmarked
     // show the AddEditBookmarkHanger control; saving/deleting takes place there
     let siteDetail = siteUtil.getDetailFromFrame(this.activeFrame, siteTags.BOOKMARK)
     const key = siteUtil.getSiteKey(siteDetail)
@@ -109,11 +110,6 @@ class NavigationBar extends React.Component {
     }
   }
 
-  get bookmarked () {
-    return this.props.activeFrameKey !== undefined &&
-      this.props.bookmarked
-  }
-
   componentDidMount () {
     ipc.on(messages.SHORTCUT_ACTIVE_FRAME_BOOKMARK, () => this.onToggleBookmark())
     ipc.on(messages.SHORTCUT_ACTIVE_FRAME_REMOVE_BOOKMARK, () => this.onToggleBookmark())
@@ -129,10 +125,12 @@ class NavigationBar extends React.Component {
     const activeTabShowingMessageBox = tabState.isShowingMessageBox(state, activeTabId)
     const bookmarkDetail = currentWindow.get('bookmarkDetail')
     const mouseInTitlebar = currentWindow.getIn(['ui', 'mouseInTitlebar'])
-    const title = activeFrame.get('title') || ''
+    const title = activeFrame.get('title', '')
     const loading = activeFrame.get('loading')
-    const location = activeFrame.get('location') || ''
-    const navbar = activeFrame.get('navbar') || Immutable.Map()
+    const location = activeFrame.get('location', '')
+    const locationId = getBaseUrl(location)
+    const publisherId = state.getIn(['locationInfo', locationId, 'publisher'])
+    const navbar = activeFrame.get('navbar', Immutable.Map())
 
     const hasTitle = title && location && title !== location.replace(/^https?:\/\//, '')
     const titleMode = activeTabShowingMessageBox ||
@@ -148,33 +146,29 @@ class NavigationBar extends React.Component {
       )
 
     const props = {}
-
-    props.navbar = navbar
-    props.sites = state.get('sites') // TODO(nejc) remove, primitives only
+    // used in renderer
     props.activeFrameKey = activeFrameKey
-    props.location = location
-    props.title = title
-    props.bookmarked = activeTab && activeTab.get('bookmarked')
-    props.partitionNumber = activeFrame.get('partitionNumber') || 0
-    props.isSecure = activeFrame.getIn(['security', 'isSecure'])
-    props.loading = loading
-    props.showBookmarkHanger = bookmarkDetail && bookmarkDetail.get('isBookmarkHanger')
-    props.mouseInTitlebar = mouseInTitlebar
-    props.settings = state.get('settings')
-    props.siteSettings = state.get('siteSettings')
-    props.synopsis = state.getIn(['publisherInfo', 'synopsis']) || new Immutable.Map()
-    props.activeTabShowingMessageBox = activeTabShowingMessageBox
-    props.locationInfo = state.get('locationInfo')
     props.titleMode = titleMode
-    props.isWideURLbarEnabled = getSetting(settings.WIDE_URL_BAR)
+    props.dontRender = activeFrameKey === undefined ||
+      state.get('siteSettings') === undefined
+    props.isBookmarked = props.activeFrameKey !== undefined &&
+      activeTab && activeTab.get('bookmarked')
+    props.isWideUrlBarEnabled = getSetting(settings.WIDE_URL_BAR)
+    props.showBookmarkHanger = bookmarkDetail && bookmarkDetail.get('isBookmarkHanger')
+    props.isLoading = loading
+    props.showPublisherToggle = publisherState.shouldShowAddPublisherButton(state, location, publisherId)
+    props.showHomeButton = !props.titleMode && getSetting(settings.SHOW_HOME_BUTTON)
+
+    // used in other functions
+    props.navbar = navbar // TODO(nejc) remove, primitives only
+    props.sites = state.get('sites') // TODO(nejc) remove, primitives only
     props.activeTabId = activeTabId
 
     return props
   }
 
   render () {
-    if (this.props.activeFrameKey === undefined ||
-        this.props.siteSettings === undefined) {
+    if (this.props.dontRender) {
       return null
     }
 
@@ -183,7 +177,7 @@ class NavigationBar extends React.Component {
       data-frame-key={this.props.activeFrameKey}
       className={cx({
         titleMode: this.props.titleMode,
-        [css(styles.navigator_wide)]: this.props.isWideURLbarEnabled
+        [css(styles.navigator_wide)]: this.props.isWideUrlBarEnabled
       })}>
       {
         this.props.showBookmarkHanger
@@ -193,7 +187,7 @@ class NavigationBar extends React.Component {
       {
         this.props.titleMode
         ? null
-        : this.props.loading
+        : this.props.isLoading
           ? <span className='navigationButtonContainer'>
             <button data-l10n-id='stopButton'
               className='normalizeButton navigationButton stopButton'
@@ -208,7 +202,7 @@ class NavigationBar extends React.Component {
           </span>
       }
       {
-        !this.props.titleMode && getSetting(settings.SHOW_HOME_BUTTON)
+        this.props.showHomeButton
         ? <span className='navigationButtonContainer'>
           <button
             data-test-id='homeButton'
@@ -222,11 +216,11 @@ class NavigationBar extends React.Component {
         {
           !this.props.titleMode
           ? <span className='bookmarkButtonContainer'>
-            <button data-l10n-id={this.bookmarked ? 'removeBookmarkButton' : 'addBookmarkButton'}
+            <button data-l10n-id={this.props.isBookmarked ? 'removeBookmarkButton' : 'addBookmarkButton'}
               className={cx({
                 navigationButton: true,
                 bookmarkButton: true,
-                removeBookmarkButton: this.bookmarked,
+                removeBookmarkButton: this.props.isBookmarked,
                 withHomeButton: getSetting(settings.SHOW_HOME_BUTTON),
                 normalizeButton: true
               })}
@@ -240,18 +234,11 @@ class NavigationBar extends React.Component {
         onStop={this.onStop}
         />
       {
-        isSourceAboutUrl(this.props.location)
-        ? null
-        : <div className='endButtons'>
-          {
-            <PublisherToggle
-              location={this.props.location}
-              locationInfo={this.props.locationInfo}
-              siteSettings={this.props.siteSettings}
-              synopsis={this.props.synopsis}
-            />
-          }
+        this.props.showPublisherToggle
+        ? <div className='endButtons'>
+          <PublisherToggle />
         </div>
+        : null
       }
     </div>
   }
diff --git a/app/renderer/components/navigation/publisherToggle.js b/app/renderer/components/navigation/publisherToggle.js
index c98ff9a2b47..5a70cf20142 100644
--- a/app/renderer/components/navigation/publisherToggle.js
+++ b/app/renderer/components/navigation/publisherToggle.js
@@ -3,22 +3,23 @@
  * You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 const React = require('react')
+const Immutable = require('immutable')
 const {StyleSheet, css} = require('aphrodite')
 
 // Components
-const ImmutableComponent = require('../immutableComponent')
+const ReduxComponent = require('../reduxComponent')
 const BrowserButton = require('../common/browserButton')
 
 // Actions
 const appActions = require('../../../../js/actions/appActions')
 
-// Constants
-const settings = require('../../../../js/constants/settings')
+// State
+const publisherState = require('../../../common/lib/publisherUtil')
 
 // Utils
-const {getSetting} = require('../../../../js/settings')
-const {getHostPattern, isHttpOrHttps} = require('../../../../js/lib/urlutil')
+const {getHostPattern} = require('../../../../js/lib/urlutil')
 const {getBaseUrl} = require('../../../../js/lib/appUrlUtil')
+const frameStateUtil = require('../../../../js/state/frameStateUtil')
 
 // Style
 const globalStyles = require('../styles/global')
@@ -27,105 +28,67 @@ const fundVerifiedPublisherImage = require('../../../extensions/brave/img/urlbar
 const noFundUnverifiedPublisherImage = require('../../../extensions/brave/img/urlbar/browser_URL_fund_no.svg')
 const fundUnverifiedPublisherImage = require('../../../extensions/brave/img/urlbar/browser_URL_fund_yes.svg')
 
-class PublisherToggle extends ImmutableComponent {
-  constructor () {
-    super()
+class PublisherToggle extends React.Component {
+  constructor (props) {
+    super(props)
     this.onAuthorizePublisher = this.onAuthorizePublisher.bind(this)
   }
 
-  get locationId () {
-    return getBaseUrl(this.props.location)
-  }
-
-  get publisherId () {
-    return this.props.locationInfo && this.props.locationInfo.getIn([this.locationId, 'publisher'])
-  }
-
-  get hostSettings () {
-    const hostPattern = getHostPattern(this.publisherId)
-    return this.props.siteSettings.get(hostPattern)
-  }
-
-  get validPublisherSynopsis () {
-    // If session is clear then siteSettings is undefined and icon
-    // will never be shown, but synopsis may not be empty.
-    // In such cases let's check if synopsis matches current publisherId
-    return !!this.props.synopsis.map(entry => entry.get('site')).includes(this.publisherId)
-  }
-
-  get enabledForPaymentsPublisher () {
-    // All publishers will be enabled by default if AUTO_SUGGEST is ON,
-    // excluding publishers defined on ledger's exclusion list
-    const excluded = this.props.locationInfo && this.props.locationInfo.getIn([this.locationId, 'exclude'])
-    const autoSuggestSites = getSetting(settings.AUTO_SUGGEST_SITES)
-
-      // hostSettings is undefined until user hit addFunds button.
-      // For such cases check autoSuggestSites for eligibility.
-    return this.hostSettings
-      ? this.hostSettings.get('ledgerPayments') !== false
-      : this.validPublisherSynopsis || (autoSuggestSites && !excluded)
-  }
-
-  get verifiedPublisher () {
-    return this.props.locationInfo && this.props.locationInfo.getIn([this.locationId, 'verified'])
-  }
-
-  get visiblePublisher () {
-    // ledgerPaymentsShown is undefined by default until
-    // user decide to permanently hide the publisher,
-    // so for icon to be shown it can be everything but false
-    const ledgerPaymentsShown = this.hostSettings && this.hostSettings.get('ledgerPaymentsShown')
-    return typeof ledgerPaymentsShown === 'boolean'
-      ? ledgerPaymentsShown
-      : true
-  }
-
-  get shouldShowAddPublisherButton () {
-    return getSetting(settings.PAYMENTS_ENABLED) &&
-      isHttpOrHttps(this.props.location) &&
-      this.visiblePublisher
-  }
-
   get l10nString () {
     let l10nData = 'disabledPublisher'
-    if (this.verifiedPublisher && !this.enabledForPaymentsPublisher) {
+    if (this.props.isVerifiedPublisher && !this.props.isEnabledForPaymentsPublisher) {
       l10nData = 'verifiedPublisher'
-    } else if (this.enabledForPaymentsPublisher) {
+    } else if (this.props.isEnabledForPaymentsPublisher) {
       l10nData = 'enabledPublisher'
     }
     return l10nData
   }
 
   onAuthorizePublisher () {
-    const hostPattern = getHostPattern(this.publisherId)
-    appActions.changeSiteSetting(hostPattern, 'ledgerPayments', !this.enabledForPaymentsPublisher)
+    appActions.changeSiteSetting(this.props.hostPattern, 'ledgerPayments', !this.props.isEnabledForPaymentsPublisher)
+  }
+
+  mergeProps (state, ownProps) {
+    const currentWindow = state.get('currentWindow')
+    const activeFrame = frameStateUtil.getActiveFrame(currentWindow) || Immutable.Map()
+    const location = activeFrame.get('location', '')
+    const locationId = getBaseUrl(location)
+    const locationInfo = state.get('locationInfo', Immutable.Map())
+
+    const props = {}
+    // used in renderer
+    props.isEnabledForPaymentsPublisher = publisherState.enabledForPaymentsPublisher(state, locationId)
+    props.isVerifiedPublisher = locationInfo.getIn([locationId, 'verified'])
+
+    // used in functions
+    props.publisherId = locationInfo.getIn([locationId, 'publisher'])
+    props.hostPattern = getHostPattern(props.publisherId)
+
+    return props
   }
 
   render () {
-    if (!this.props.locationInfo) {
-      return null
-    }
-    return this.shouldShowAddPublisherButton
-      ? <span
-        data-test-id='publisherButton'
-        data-test-authorized={this.enabledForPaymentsPublisher}
-        data-test-verified={this.verifiedPublisher}
-        className={css(styles.addPublisherButtonContainer)}>
-        <BrowserButton
-          custom={[
-            !this.enabledForPaymentsPublisher && this.verifiedPublisher && styles.noFundVerified,
-            this.enabledForPaymentsPublisher && this.verifiedPublisher && styles.fundVerified,
-            !this.enabledForPaymentsPublisher && !this.verifiedPublisher && styles.noFundUnverified,
-            this.enabledForPaymentsPublisher && !this.verifiedPublisher && styles.fundUnverified
-          ]}
-          data-l10n-id={this.l10nString}
-          onClick={this.onAuthorizePublisher}
-        />
-      </span>
-      : null
+    return <span
+      data-test-id='publisherButton'
+      data-test-authorized={this.props.isEnabledForPaymentsPublisher}
+      data-test-verified={this.props.isVerifiedPublisher}
+      className={css(styles.addPublisherButtonContainer)}>
+      <BrowserButton
+        custom={[
+          !this.props.isEnabledForPaymentsPublisher && this.props.isVerifiedPublisher && styles.noFundVerified,
+          this.props.isEnabledForPaymentsPublisher && this.props.isVerifiedPublisher && styles.fundVerified,
+          !this.props.isEnabledForPaymentsPublisher && !this.props.isVerifiedPublisher && styles.noFundUnverified,
+          this.props.isEnabledForPaymentsPublisher && !this.props.isVerifiedPublisher && styles.fundUnverified
+        ]}
+        data-l10n-id={this.l10nString}
+        onClick={this.onAuthorizePublisher}
+      />
+    </span>
   }
 }
 
+module.exports = ReduxComponent.connect(PublisherToggle)
+
 const styles = StyleSheet.create({
   addPublisherButtonContainer: {
     boxSizing: 'border-box',
@@ -166,5 +129,3 @@ const styles = StyleSheet.create({
     backgroundSize: '18px'
   }
 })
-
-module.exports = PublisherToggle
diff --git a/app/renderer/components/navigation/urlBar.js b/app/renderer/components/navigation/urlBar.js
index 9f82b3dd09f..f5faf17eeb5 100644
--- a/app/renderer/components/navigation/urlBar.js
+++ b/app/renderer/components/navigation/urlBar.js
@@ -39,6 +39,7 @@ const {eventElHasAncestorWithClasses, isForSecondaryAction} = require('../../../
 const {getBaseUrl, isUrl, isIntermediateAboutPage} = require('../../../../js/lib/appUrlUtil')
 const {getCurrentWindowId} = require('../../currentWindow')
 const {normalizeLocation} = require('../../../common/lib/suggestion')
+const publisherUtil = require('../../../common/lib/publisherUtil')
 
 // Icons
 const iconNoScript = require('../../../../img/url-bar-no-script.svg')
@@ -458,12 +459,12 @@ class UrlBar extends React.Component {
   mergeProps (state, ownProps) {
     const currentWindow = state.get('currentWindow')
     const activeFrame = frameStateUtil.getActiveFrame(currentWindow) || Immutable.Map()
-    const activeTabId = activeFrame.get('tabId') || tabState.TAB_ID_NONE
+    const activeTabId = activeFrame.get('tabId', tabState.TAB_ID_NONE)
 
-    const location = activeFrame.get('location') || ''
+    const location = activeFrame.get('location', '')
     const baseUrl = getBaseUrl(location)
-    const urlbar = activeFrame.getIn(['navbar', 'urlbar']) || Immutable.Map()
-    const history = (activeFrame.get('history') || new Immutable.List())
+    const urlbar = activeFrame.getIn(['navbar', 'urlbar'], Immutable.Map())
+    const history = (activeFrame.get('history', new Immutable.List()))
     const canGoForward = activeTabId === tabState.TAB_ID_NONE ? false : tabState.canGoForward(state, activeTabId)
     const urlbarLocation = urlbar.get('location')
     const locationValue = (isIntermediateAboutPage(urlbarLocation) && history.size > 0 && !canGoForward)
@@ -474,12 +475,6 @@ class UrlBar extends React.Component {
 
     // TODO(bridiver) - these definitely needs a helpers
     const publisherId = state.getIn(['locationInfo', baseUrl, 'publisher'])
-    const hostPattern = UrlUtil.getHostPattern(publisherId)
-    const hostSettings = siteSettings.getSiteSettingsForHostPattern(state.get('settings'), hostPattern)
-    const ledgerPaymentsShown = hostSettings && hostSettings.get('ledgerPaymentsShown')
-    const visiblePublisher = typeof ledgerPaymentsShown === 'boolean' ? ledgerPaymentsShown : true
-    const isPublisherButtonEnabled = getSetting(settings.PAYMENTS_ENABLED) &&
-        UrlUtil.isHttpOrHttps(location) && visiblePublisher
 
     const activateSearchEngine = urlbar.getIn(['searchDetail', 'activateSearchEngine'])
     const urlbarSearchDetail = urlbar.get('searchDetail')
@@ -514,7 +509,7 @@ class UrlBar extends React.Component {
     props.noScriptIsVisible = currentWindow.getIn(['ui', 'noScriptInfo', 'isVisible']) || false
     props.menubarVisible = ownProps.menubarVisible
     props.activeTabShowingMessageBox = tabState.isShowingMessageBox(state, activeTabId)
-    props.noBorderRadius = isPublisherButtonEnabled
+    props.publisherButtonVisible = publisherUtil.shouldShowAddPublisherButton(state, location, publisherId)
     props.onStop = ownProps.onStop
     props.titleMode = ownProps.titleMode
     props.locationValue = locationValue
@@ -544,7 +539,7 @@ class UrlBar extends React.Component {
       className={cx({
         urlbarForm: true,
         [css(styles.urlbarForm_wide)]: this.props.isWideURLbarEnabled,
-        noBorderRadius: this.props.noBorderRadius
+        noBorderRadius: this.props.publisherButtonVisible
       })}
       action='#'
       id='urlbar'
diff --git a/test/unit/app/common/lib/publisherUtilTest.js b/test/unit/app/common/lib/publisherUtilTest.js
new file mode 100644
index 00000000000..93a149f902b
--- /dev/null
+++ b/test/unit/app/common/lib/publisherUtilTest.js
@@ -0,0 +1,71 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this file,
+ * You can obtain one at http://mozilla.org/MPL/2.0/. */
+/* global describe, it, before, beforeEach, after */
+
+const assert = require('assert')
+const mockery = require('mockery')
+const Immutable = require('immutable')
+
+require('../../../braveUnit')
+
+const state = Immutable.fromJS({
+  siteSettings: {
+    'https?://brave.com': {
+      ledgerPayments: false
+    }
+  }
+})
+
+describe('publisherUtil test', function () {
+  let publisherUtil, getSetting
+
+  describe('shouldShowAddPublisherButton', function () {
+    before(function () {
+      mockery.enable({
+        warnOnReplace: false,
+        warnOnUnregistered: false,
+        useCleanCache: true
+      })
+
+      mockery.registerMock('../../../js/settings', {
+        getSetting: () => getSetting
+      })
+      publisherUtil = require('../../../../../app/common/lib/publisherUtil')
+    })
+
+    beforeEach(function () {
+      getSetting = true
+    })
+
+    after(function () {
+      mockery.disable()
+    })
+
+    it('location is empty', function () {
+      const result = publisherUtil.shouldShowAddPublisherButton(state, '', 'brave.com')
+      assert.equal(result, false)
+    })
+
+    it('location is about page', function () {
+      const result = publisherUtil.shouldShowAddPublisherButton(state, 'about:about', 'about:about')
+      assert.equal(result, false)
+    })
+
+    it('location is file', function () {
+      const result = publisherUtil.shouldShowAddPublisherButton(state, 'file://test.txt', 'test.txt')
+      assert.equal(result, false)
+    })
+
+    it('everything is ok', function () {
+      const result = publisherUtil.shouldShowAddPublisherButton(state, 'https://brave.com', 'brave.com')
+      assert.equal(result, true)
+    })
+
+    it('payment is disabled', function () {
+      getSetting = false
+      const result = publisherUtil.shouldShowAddPublisherButton(state, 'https://brave.com', 'brave.com')
+      assert.equal(result, false)
+    })
+  })
+})
diff --git a/test/unit/app/renderer/components/navigation/publisherToggleTest.js b/test/unit/app/renderer/components/navigation/publisherToggleTest.js
index fe461a397d2..0ec3ec0b01a 100644
--- a/test/unit/app/renderer/components/navigation/publisherToggleTest.js
+++ b/test/unit/app/renderer/components/navigation/publisherToggleTest.js
@@ -6,10 +6,10 @@ const Immutable = require('immutable')
 const fakeElectron = require('../../../../lib/fakeElectron')
 const settingsConst = require('../../../../../../js/constants/settings')
 const {getHostPattern} = require('../../../../../../js/lib/urlutil')
-let PublisherToggle
 require('../../../../braveUnit')
 
 describe('PublisherToggle component', function () {
+  let PublisherToggle
   const getUrlOrigin = url => url.split('/').slice(0, 3).join('/')
   const getHostName = url => getUrlOrigin(url).split('/').slice(2).join('/')
   const getPattern = pattern => getHostPattern(getHostName(pattern))